Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take into account max_headroom in disk watermark calculations #93157

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Take into account max_headroom in disk watermark calculations #93157

merged 3 commits into from
Jan 24, 2023
+12 −3

Conversation

fcofdez
Copy link
Contributor

@fcofdez fcofdez commented Jan 23, 2023

Closes #93155

@fcofdez fcofdez requested a review from gmarouli January 23, 2023 13:43
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine
Copy link
Collaborator

Hi @fcofdez, I've created a changelog YAML for you.

@fcofdez
Copy link
Contributor Author

fcofdez commented Jan 23, 2023

@elasticmachine update branch

andreidan
andreidan approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch Francisco. Thanks for fixing this!

@fcofdez fcofdez merged commit a1bf143 into elastic:main Jan 24, 2023
@fcofdez
Copy link
Contributor Author

fcofdez commented Jan 24, 2023

Thanks for the review @andreidan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreidan andreidan andreidan approved these changes

@gmarouli gmarouli Awaiting requested review from gmarouli

Assignees
No one assigned
Labels
>bug :Data Management/Health Team:Data Management Meta label for data/management team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disk health indicator doesn't take into account watermark.low/high.max_headroom
4 participants
@fcofdez @elasticsearchmachine @andreidan @elasticmachine