ActionListener#notifyOnce should release delegate on completion #92452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to keep hold of the delegate after completing it, and in some cases this might hold on to excessive heap. With this commit we drop the reference to the delegate when it's complete. Closes elastic#92451
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
approved these changes
Dec 19, 2022
|
Yeah that'd be nice, but I think it would mean we have to force a GC? I tried, but I didn't manage to get it to work anyway. |
|
@elasticmachine please run elasticsearch-ci/part-3 |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Dec 21, 2022
Like elastic#92452 but for `RunOnce`.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Dec 22, 2022
Like elastic#92452 and elastic#92507 but for `Releasables#releaseOnce`: there's no need to keep hold of the wrapped releasable after closing it, and in some cases this might hold on to excessive heap. With this commit we drop the reference to the delegate when it's complete.
DaveCTurner
added a commit
that referenced
this pull request
Dec 23, 2022
Like #92452 but for `RunOnce`.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Dec 24, 2022
Like elastic#92452 but for `RunOnce`.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 15, 2023
We recently adjusted `RunOnce`, `Releasables#releaseOnce` and `ActionListener#notifyOnce` so that once they have fired they drop the now-unnecessary reference to the delegate. This commit introduces tests to verify that this reference does genuinely become unreachable (i.e. available for garbage collection) as expected. It also fixes a bug in `ActionListener#notifyOnce` which caused us to unexpectedly retain a reference to the delegate 🤦 Relates elastic#92452 Relates elastic#92507 Relates elastic#92537
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 16, 2023
We recently adjusted `RunOnce`, `Releasables#releaseOnce` and `ActionListener#notifyOnce` so that once they have fired they drop the now-unnecessary reference to the delegate. This commit introduces tests to verify that this reference does genuinely become unreachable (i.e. available for garbage collection) as expected. It also fixes a bug in `ActionListener#notifyOnce` which caused us to unexpectedly retain a reference to the delegate 🤦 Relates elastic#92452 Relates elastic#92507 Relates elastic#92537
I suspect this might be because this commit had a subtle bug 🤦 - see #92928 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 16, 2023
We recently adjusted `RunOnce`, `Releasables#releaseOnce` and `ActionListener#notifyOnce` so that once they have fired they drop the now-unnecessary reference to the delegate. This commit introduces tests to verify that this reference does genuinely become unreachable (i.e. available for garbage collection) as expected. It also fixes a bug in `ActionListener#notifyOnce` which caused us to unexpectedly retain a reference to the delegate 🤦 Relates #92452 Relates #92507 Relates #92537
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 17, 2023
Recent improvements to the primitives for writing async code (particularly elastic#92452 and elastic#92620) mean that we can enormously simplify `TransportNodesAction`. In particular, we can avoid accumulating an intermediate array of responses for later processing in favour of just accumulating the successes and failures into their final separate lists. We also no longer need to use a separate `NodesResponseTracker` to discard responses on cancellation.
DaveCTurner
added a commit
that referenced
this pull request
Jan 19, 2023
Recent improvements to the primitives for writing async code (particularly #92452 and #92620) mean that we can enormously simplify `TransportNodesAction`. In particular, we can avoid accumulating an intermediate array of responses for later processing in favour of just accumulating the successes and failures into their final separate lists. We also no longer need to use a separate `NodesResponseTracker` to discard responses on cancellation.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 2, 2023
Similarly to elastic#92987, recent improvements to the primitives for writing async code (particularly elastic#92452 and elastic#92620) mean that we can enormously simplify `TransportBroadcastByNodeAction`. In particular, we can avoid accumulating an intermediate array of responses for later processing in favour of just accumulating the successes and failures into their final separate lists. We also no longer need to use a separate `NodesResponseTracker` to discard responses on cancellation. Finally, we can now discard shard-level responses more promptly on cancellation.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 7, 2023
Similarly to #92987, recent improvements to the primitives for writing async code (particularly #92452 and #92620) mean that we can enormously simplify `TransportBroadcastByNodeAction`. In particular, we can avoid accumulating an intermediate array of responses for later processing in favour of just accumulating the successes and failures into their final separate lists. We also no longer need to use a separate `NodesResponseTracker` to discard responses on cancellation. Finally, we can now discard shard-level responses more promptly on cancellation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to keep hold of the delegate after completing it, and in some cases this might hold on to excessive heap. With this commit we drop the reference to the delegate when it's complete.
Closes #92451