Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused methods and classes from HLRC (again) #92030

Merged

Conversation

joegallo
Copy link
Contributor

@joegallo joegallo commented Nov 30, 2022

Related to #83423, follow up to #92012

This time by first searching for usages of methods and deleting them if none were found, rather than relying on IntelliJ to identify unused methods. It wouldn't shock me if I got something wrong and need to add some of these back, so no point in reviewing until Jenkins approves.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@joegallo joegallo added the Team:Data Management Meta label for data/management team label Nov 30, 2022
@elasticsearchmachine elasticsearchmachine removed the Team:Data Management Meta label for data/management team label Nov 30, 2022
@joegallo joegallo changed the title Remove unused methods and classes from HLRC(again) Remove unused methods and classes from HLRC (again) Nov 30, 2022
@joegallo joegallo requested a review from dakrone November 30, 2022 18:08
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joegallo joegallo merged commit 2b8fde6 into elastic:main Nov 30, 2022
@joegallo joegallo deleted the tree-shake-rest-high-level-client-again branch November 30, 2022 18:34
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Dec 2, 2022
* upstream/main: (209 commits)
  Remove unused methods and classes from HLRC (elastic#92030)
  Clean up on exception while chunking XContent (elastic#92024)
  Add profiling plugin (elastic#91640)
  Remove unused methods and classes from HLRC (elastic#92012)
  Remove IndexerState from HLRC (elastic#92023)
  Ensure cached time elapses in ClusterServiceIT (elastic#91986)
  Chunked encoding for RestGetIndicesAction (elastic#92016)
  Simplify shardsWithState (elastic#91991)
  [DOCS] Updates ML decider docs by mentioning CPU as scaling criterion (elastic#92018)
  Add chunking to ClusterState.Custom impls (elastic#91963)
  Speedup time_series agg by caching current tsid ordinal, parent bucket ordinal and buck ordinal (elastic#91784)
  Drop the ingest listener call count tracking (elastic#92003)
  [DOCS] fixes issue number 91889 - missing [discrete] header (elastic#91976)
  Fix PersistentTasksClusterServiceTests (elastic#92002)
  [docs] Update search-settings documentation to reflect the fact that the indices.query.bool.max_clause_count setting has been deprecated (elastic#91811)
  Clarify writability in Netty4HttpPipeliningHandler (elastic#91982)
  Load stable plugins as synthetic modules (elastic#91869)
  Handle any exception thrown while generating source for an IngestDocument (elastic#91981)
  fixing Apache HttpHost url on java-rest doc (elastic#91945)
  Implement repair functionality for aliases colliding with indices bug (elastic#91887)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue Team:Clients Meta label for clients team v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants