Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix look-ahead-time setting validation for release builds #88087

Merged

Conversation

benwtrent
Copy link
Member

Follow up to #87847

Adding a setting polling callback will fail if the setting is not there.

@benwtrent benwtrent requested review from nik9000 and martijnvg June 27, 2022 18:36
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 27, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@benwtrent
Copy link
Member Author

run elasticsearch-ci/packaging-tests-unix-sample

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this @benwtrent!

@martijnvg
Copy link
Member

run elasticsearch-ci/packaging-tests-unix-sample

@benwtrent
Copy link
Member Author

@elasticmachine update branch

@benwtrent benwtrent merged commit 87bc952 into elastic:master Jun 28, 2022
@benwtrent benwtrent deleted the feature/fix-timeseries-param-checker branch June 28, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants