Include the calling transport task in the method for individual node task operations #88081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
approved these changes
Jun 28, 2022
| @@ -113,6 +113,7 @@ protected void processTasks(final FollowStatsAction.StatsRequest request, final | |||
|
|
|||
| @Override | |||
| protected void taskOperation( | |||
| Task transportTask, | |||
There was a problem hiding this comment.
Harmonisation nit:
Suggested change
| Task transportTask, | |
| final Task transportTask, |
| */ | ||
| protected abstract void taskOperation(TasksRequest request, OperationTask task, ActionListener<TaskResponse> listener); | ||
| protected abstract void taskOperation( | ||
| Task transportTask, |
There was a problem hiding this comment.
I worry a bit about the name transportTask, given that many of these tasks actions will be iterating over transport tasks too. What about requestTask or actionTask perhaps?
There was a problem hiding this comment.
actionTask is nice. I will rename to that
|
@elasticmachine update branch |
benwtrent
added a commit
that referenced
this pull request
Jul 20, 2022
We pass the actionTask to the subsequent task action so that the task action can be cancelled if the upstream tasks are cancelled. But, the actionTask passed is created by the `NodeTaskRequest`, which isn't cancellable. This commit addresses this discrepancy and allows for down stream task actions to be cancelled if the upstream http connections are closed. Related to: #88081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the parent transport task is cancelled, there is no way to propagate the cancellation to any NEW transport action inacted by
TransportTasksAction#taskOperation.This commit passes the originating transport task into
TransportTasksAction#taskOperationso that any additional transport actions can be cancelled if the originating transport task is cancelled.Note: it is up to the implementer to enable this cancellation logic. This commit simply updates the framework to make it possible.