[Transforms] fix bug when unsetting retention policy #87711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @benwtrent, I've created a changelog YAML for you. |
davidkyle
reviewed
Jun 16, 2022
| @@ -534,6 +535,11 @@ public List<NamedWriteableRegistry.Entry> getNamedWriteables() { | |||
| TransformField.TIME.getPreferredName(), | |||
| TimeRetentionPolicyConfig::new | |||
| ), | |||
| new NamedWriteableRegistry.Entry( | |||
There was a problem hiding this comment.
TransformNamedXContentProvider is also missing the NullRetentionPolicyConfig named writable
There was a problem hiding this comment.
@davidkyle it isn't required. This thing is never written to XContent. But I can add it for completeness.
There was a problem hiding this comment.
Please do I think it is worth having to avoid a similar problem in future
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jun 16, 2022
It is currently not possible to unset the retention policy in a typical multi-node cluster. This commit fixes that bug. If unsetting the retention policy failed, it would fail looking like the following error: ``` An error occurred calling the API endpoint to update transforms. Bad Request: [illegal_argument_exception: [illegal_argument_exception] Reason: Unknown NamedWriteable [org.elasticsearch.xpack.core.transform.transforms.RetentionPolicyConfig][null_retention_policy]]: Unknown NamedWriteable [org.elasticsearch.xpack.core.transform.transforms.RetentionPolicyConfig][null_retention_policy] ``` closes: elastic#87688
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jun 16, 2022
It is currently not possible to unset the retention policy in a typical multi-node cluster. This commit fixes that bug. If unsetting the retention policy failed, it would fail looking like the following error: ``` An error occurred calling the API endpoint to update transforms. Bad Request: [illegal_argument_exception: [illegal_argument_exception] Reason: Unknown NamedWriteable [org.elasticsearch.xpack.core.transform.transforms.RetentionPolicyConfig][null_retention_policy]]: Unknown NamedWriteable [org.elasticsearch.xpack.core.transform.transforms.RetentionPolicyConfig][null_retention_policy] ``` closes: elastic#87688
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 16, 2022
It is currently not possible to unset the retention policy in a typical multi-node cluster. This commit fixes that bug. If unsetting the retention policy failed, it would fail looking like the following error: ``` An error occurred calling the API endpoint to update transforms. Bad Request: [illegal_argument_exception: [illegal_argument_exception] Reason: Unknown NamedWriteable [org.elasticsearch.xpack.core.transform.transforms.RetentionPolicyConfig][null_retention_policy]]: Unknown NamedWriteable [org.elasticsearch.xpack.core.transform.transforms.RetentionPolicyConfig][null_retention_policy] ``` closes: #87688
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 16, 2022
It is currently not possible to unset the retention policy in a typical multi-node cluster. This commit fixes that bug. If unsetting the retention policy failed, it would fail looking like the following error: ``` An error occurred calling the API endpoint to update transforms. Bad Request: [illegal_argument_exception: [illegal_argument_exception] Reason: Unknown NamedWriteable [org.elasticsearch.xpack.core.transform.transforms.RetentionPolicyConfig][null_retention_policy]]: Unknown NamedWriteable [org.elasticsearch.xpack.core.transform.transforms.RetentionPolicyConfig][null_retention_policy] ``` closes: #87688
This was referenced Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently not possible to unset the retention policy in a typical multi-node cluster.
This commit fixes that bug. If unsetting the retention policy failed, it would fail looking like the following error:
closes: #87688