Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] adjust change_point to not throw with too few buckets #87297

Conversation

benwtrent
Copy link
Member

It can be frustrating for agg consumers to handle failure modes when we should just indicate that there were too few buckets to calculate the change.

Other aggs simply return NaN or empty results when too few docs are calculated. We should follow suit for continuity of experience.

@benwtrent benwtrent added >non-issue :ml Machine learning v8.4.0 labels Jun 1, 2022
@benwtrent benwtrent force-pushed the feature/ml-improve-changepoint-agg-response branch from 177b698 to 2c77695 Compare June 1, 2022 17:02
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Jun 1, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Jun 1, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent
Copy link
Member Author

@elasticmachine update branch

@benwtrent
Copy link
Member Author

run elasticsearch-ci/part-2

@benwtrent benwtrent merged commit 3e3c071 into elastic:master Jun 6, 2022
@benwtrent benwtrent deleted the feature/ml-improve-changepoint-agg-response branch June 6, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >non-issue Team:Clients Meta label for clients team Team:ML Meta label for the ML team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants