Fixing testComplicatedBucketPath for avg bucket agg #87161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
benwtrent
commented
May 26, 2022
Comment on lines
-175
to
-195
| avgResult = searchAndReduce( | ||
| indexSearcher, | ||
| query, | ||
| avgBuilder, | ||
| 10000, | ||
| new MappedFieldType[] { fieldType, valueFieldType, keywordField } | ||
| ); | ||
| histogramResult = searchAndReduce( | ||
| indexSearcher, | ||
| query, | ||
| histo, | ||
| 10000, | ||
| new MappedFieldType[] { fieldType, valueFieldType, keywordField } | ||
| ); | ||
| internalTerms = searchAndReduce( | ||
| indexSearcher, | ||
| query, | ||
| termsBuilder, | ||
| 10000, | ||
| new MappedFieldType[] { fieldType, valueFieldType, keywordField } | ||
| ); |
There was a problem hiding this comment.
Re-reading the test, I realized that none of these were necessary. Cleaning up.
| try (IndexReader indexReader = DirectoryReader.open(directory)) { | ||
| IndexSearcher indexSearcher = newSearcher(indexReader, true, true); | ||
| IndexSearcher indexSearcher = newIndexSearcher(indexReader); |
There was a problem hiding this comment.
This is the key change. I was using the newSearcher method from lucene tests which randomly wraps it as a parallel reader, which we don't support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was erroneously creating a test Lucene index reader directly. This means that sometimes the reader was wrapped as a Parallel (threaded) reader which we don't support yet.
This commit cleans up the test and uses AggregatorTestCase#newIndexSearcher directly.
closes #87155