Reindex support for TSDB creating indices #86704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
This teaches reindex to infer if the destination index is a tsdb index if it doesn't yet exist. It looks at the templates that apply to the index and checks what settings they use. So you should be able to reindex into a non-existant index and automatically get the tsdb support.
|
Pinging @elastic/clients-team (Team:Clients) |
martijnvg
approved these changes
May 12, 2022
| @@ -53,6 +70,16 @@ private ClusterState stateWithIndex(Settings.Builder settings) { | |||
| return ClusterState.builder(ClusterState.EMPTY_STATE).metadata(Metadata.builder(Metadata.EMPTY_METADATA).put(meta)).build(); | |||
| } | |||
|
|
|||
| private Settings.Builder standardSettings() { | |||
| return Settings.builder().put(IndexSettings.MODE.getKey(), IndexMode.STANDARD); | |||
There was a problem hiding this comment.
maybe randomly return an empty setting? Since standard is the default.
| public void testMissingIndexWithTsdbTemplateClearsId() throws Exception { | ||
| Metadata.Builder metadata = Metadata.builder(); | ||
| metadata.put("c", new ComponentTemplate(new Template(tsdbSettings().build(), null, null), null, null)); | ||
| metadata.put("c", new ComposableIndexTemplate(List.of("dest_index"), null, List.of("c"), null, null, null)); |
There was a problem hiding this comment.
maybe randomly add the settings to component or composable index template?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This teaches reindex to infer if the destination index is a tsdb index
if it doesn't yet exist. It looks at the templates that apply to the
index and checks what settings they use. So you should be able to
reindex into a non-existant index and automatically get the tsdb
support.