Disabling users includes realm in same-user validation #86473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-security (Team:Security) |
|
Hi @n1v0lg, I've created a changelog YAML for you. |
n1v0lg
commented
May 5, 2022
...ty/src/main/java/org/elasticsearch/xpack/security/action/user/TransportSetEnabledAction.java
Show resolved
Hide resolved
ywangd
approved these changes
May 6, 2022
...ty/src/main/java/org/elasticsearch/xpack/security/action/user/TransportSetEnabledAction.java
Show resolved
Hide resolved
...ty/src/main/java/org/elasticsearch/xpack/security/action/user/TransportSetEnabledAction.java
Show resolved
Hide resolved
...c/test/java/org/elasticsearch/xpack/security/action/user/TransportSetEnabledActionTests.java
Show resolved
Hide resolved
...c/test/java/org/elasticsearch/xpack/security/action/user/TransportSetEnabledActionTests.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A validation check prevents users from disabling themselves. The check
is incorrect since it does not factor in realms. Users can have
overlapping usernames across realms, and should be able to disable
same-named users in other realms, authorization provided. This PR
tweaks the validation check to account for the source realm.