Remove remaining ImmutableOpen maps from shard stores response #86427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IndicesShardStoresResponse had ImmutableOpenInt map removed, but its use accidentally remained in serialization. Thankfully the format for immutable open maps are interchangable with read java Map. This commit switches to using the new readImmutableMap to read the store statuses. relates elastic#86239
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
approved these changes
May 4, 2022
idegtiarenko
reviewed
May 4, 2022
| }); | ||
| storeStatuses = in.readImmutableMap( | ||
| StreamInput::readString, | ||
| i -> i.readImmutableMap(StreamInput::readInt, j -> j.readList(StoreStatus::new)) |
There was a problem hiding this comment.
It would be great to have a method to read immutable list as well if possible
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
May 4, 2022
This commit adds a utility method for reading an immutable list to StreamInput. relates elastic#86427
original-brownbear
approved these changes
May 4, 2022
rjernst
added a commit
that referenced
this pull request
May 4, 2022
This commit adds a utility method for reading an immutable list to StreamInput. relates #86427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IndicesShardStoresResponse had ImmutableOpenInt map removed, but its
use accidentally remained in serialization. Thankfully the format for
immutable open maps are interchangable with read java Map. This commit
switches to using the new readImmutableMap to read the store statuses.
relates #86239