[ML] improve reliability of job stats in larger clusters #86305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @benwtrent, I've created a changelog YAML for you. |
|
@droberts195 I did some tests locally printing out the thread names on every call. Indeed we would be on a transport thread before this change. Meaning we would spin up N requests from that thread pool. Those executions would then occur on the search pool (eventually). In the call back, we are usually in the search pool, so I decided to fork that as well when gathering data stats (especially since in 7.17 its still multiple searches correct?). Project Loom cannot come fast enough... |
droberts195
approved these changes
Apr 29, 2022
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Apr 29, 2022
When gather job stats for closed jobs, we may be inadvertently executing on a transport thread. Typically, this is acceptable. But, when there are many jobs and many indices, this has a cascading effect and may cause the cluster to enter a troubling state. This is main due to how slow security checks can be for search requests when the cluster has many indices. To alleviate, gathering information about closed jobs is forked to the ML utility thread pool related: elastic#82255
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Apr 29, 2022
When gather job stats for closed jobs, we may be inadvertently executing on a transport thread. Typically, this is acceptable. But, when there are many jobs and many indices, this has a cascading effect and may cause the cluster to enter a troubling state. This is main due to how slow security checks can be for search requests when the cluster has many indices. To alleviate, gathering information about closed jobs is forked to the ML utility thread pool related: elastic#82255 (cherry picked from commit 4e481c3)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 29, 2022
…6309) When gather job stats for closed jobs, we may be inadvertently executing on a transport thread. Typically, this is acceptable. But, when there are many jobs and many indices, this has a cascading effect and may cause the cluster to enter a troubling state. This is main due to how slow security checks can be for search requests when the cluster has many indices. To alleviate, gathering information about closed jobs is forked to the ML utility thread pool related: #82255
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 29, 2022
…6310) When gather job stats for closed jobs, we may be inadvertently executing on a transport thread. Typically, this is acceptable. But, when there are many jobs and many indices, this has a cascading effect and may cause the cluster to enter a troubling state. This is main due to how slow security checks can be for search requests when the cluster has many indices. To alleviate, gathering information about closed jobs is forked to the ML utility thread pool related: #82255 (cherry picked from commit 4e481c3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When gather job stats for closed jobs, we may be inadvertently executing on a transport thread. Typically, this is acceptable. But, when there are many jobs and many indices, this has a cascading effect and may cause the cluster to enter a troubling state.
This is main due to how slow security checks can be for search requests when the cluster has many indices.
To alleviate, gathering information about closed jobs is forked to the ML utility thread pool
related: #82255