Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JndiLookup.class from the SQL command line tool #81879

Merged
merged 2 commits into from
Dec 17, 2021

Conversation

ChrisHegarty
Copy link
Contributor

@ChrisHegarty ChrisHegarty commented Dec 17, 2021

Remove the JndiLookup.class from the SQL CLI jar. The mere presence of the JndiLookup.class is not problematic, but it looks interesting and could lead to confusion for scanners. We don't need it.

The change has been verified manually.

Closes #81776

@ChrisHegarty ChrisHegarty added :Delivery/Build Build or test infrastructure v8.0.0 auto-backport Automatically create backport pull requests when merged v8.1.0 v7.16.2 v6.8.22 v7.17.0 labels Dec 17, 2021
@ChrisHegarty ChrisHegarty self-assigned this Dec 17, 2021
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Dec 17, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@ChrisHegarty ChrisHegarty removed the :Delivery/Build Build or test infrastructure label Dec 17, 2021
@elasticmachine elasticmachine removed the Team:Delivery Meta label for Delivery team label Dec 17, 2021
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.0
7.16
6.8 Commit could not be cherrypicked due to conflicts
7.17

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 81879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged v6.8.22 v7.16.2 v7.17.0 v8.0.0-rc1 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove JndiLookup.class from the SQL command line tool
4 participants