Tolerate benign log4j status messages in tests #81851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
40a3ef2 to
63c1758
Compare
ChrisHegarty
added a commit
to ChrisHegarty/elasticsearch
that referenced
this pull request
Dec 17, 2021
Tolerate either 1) the absence or, 2) the denial, of the JNDI lookup class
ChrisHegarty
added a commit
to ChrisHegarty/elasticsearch
that referenced
this pull request
Dec 17, 2021
Tolerate either 1) the absence or, 2) the denial, of the JNDI lookup class
ChrisHegarty
added a commit
to ChrisHegarty/elasticsearch
that referenced
this pull request
Dec 17, 2021
Tolerate either 1) the absence or, 2) the denial, of the JNDI lookup class
💔 Backport failed
You can use sqren/backport to manually backport by running |
ChrisHegarty
added a commit
that referenced
this pull request
Dec 17, 2021
ChrisHegarty
added a commit
that referenced
this pull request
Dec 18, 2021
Tolerate unprivileged log4j getClassLoaders calls, as if (but not exactly) like they were wrapped in doPriv. This is precautionary step as security permission exceptions have been observed during testing. This change also reverts changes to tests in the log4j 2.15 Upgrade #81709, as they should no longer be needed, given this change and changes in #81851. No explicit new test has been added in this PR, but the code in question is exercised extensively by existing tests, since the policy is set in the test framework. The test reverts mentioned above confirm that the changes are working as expected. This change is a workaround to the issue raised in log4j: https://issues.apache.org/jira/browse/LOG4J2-3236
ChrisHegarty
added a commit
that referenced
this pull request
Dec 18, 2021
pgomulka
pushed a commit
to pgomulka/elasticsearch
that referenced
this pull request
Dec 20, 2021
pgomulka
pushed a commit
to ChrisHegarty/elasticsearch
that referenced
this pull request
Dec 20, 2021
pgomulka
pushed a commit
that referenced
this pull request
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified in #81849, log4j may output warning status messages,
which are benign to tests.