Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup bulk api logic #80987

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Conversation

martijnvg
Copy link
Member

  • Always check whether it is prohibited to use custom routing on a data stream.
  • Always invoke prohibitAppendWritesInBackingIndices(...), but in the method check
    whether the operation is of type index or create.

Follow-up from #80624.

* Always check whether it is prohibited to use custom routing on a data stream.
* Always invoke prohibitAppendWritesInBackingIndices(...), but in the method check
  whether the operation is of type index or create.

Follow-up from elastic#80624.
@martijnvg martijnvg added :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >non-issue labels Nov 24, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Nov 24, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@martijnvg martijnvg requested review from henningandersen and nik9000 and removed request for henningandersen November 24, 2021 12:22
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @martijnvg

@martijnvg martijnvg merged commit daf37b4 into elastic:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants