[ML] fix model snapshot sorting when sorting by min_version #80596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
230bd8c to
f2f7937
Compare
|
This shows that the deprecation checker should have multi-node tests :(. |
przemekwitek
approved these changes
Nov 10, 2021
| .from(from) | ||
| .size(size) | ||
| .trackTotalHits(true) | ||
| .fetchSource(REMOVE_QUANTILES_FROM_SOURCE); | ||
| SearchRequest searchRequest = new SearchRequest(indexName); |
There was a problem hiding this comment.
Could this fluent builder pattern be used here too?
SearchRequest searchRequest = new SearchRequest(indexName)
.indicesOptions(...)
.source(...)
There was a problem hiding this comment.
No necessarily, we use the default indices options created in the request.
| GetModelSnapshotsAction.Request request = new GetModelSnapshotsAction.Request(jobId, null); | ||
| request.setSort("min_version"); | ||
| // Should not throw | ||
| client().execute(GetModelSnapshotsAction.INSTANCE, request).actionGet(); |
There was a problem hiding this comment.
Would it make sense to add an assertion on the result?
Or are we satisfied just knowing it doesn't throw?
There was a problem hiding this comment.
Previously, it threw a search exception. I am satisfied (for expediency) for now.
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Nov 10, 2021
…80596) When handling the missing field in sort builder, Version shouldn't be added directly, instead a string representation of the version concerned. closes: elastic#80561
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Nov 10, 2021
…80596) When handling the missing field in sort builder, Version shouldn't be added directly, instead a string representation of the version concerned. closes: elastic#80561
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling the missing field in sort builder,
Versionshouldn't be added directly, instead a string representation of the version concerned.closes: #80561