Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate primitive writes in ByteSizeCachingDirectory #79884

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Delegate primitive writes in ByteSizeCachingDirectory #79884

merged 1 commit into from
Oct 27, 2021

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Oct 27, 2021

This can possible enhance performance of those actions.

@iverase iverase added >non-issue :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v8.0.0 labels Oct 27, 2021
@iverase iverase requested a review from jpountz October 27, 2021 05:46
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Oct 27, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

jpountz
jpountz approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wonder if there are other IndexOutput delegators where we should also delegate these methods.

@iverase
Copy link
Contributor Author

iverase commented Oct 27, 2021

The only interesting one is FlushIndexOutput in CompressingOfflineSorter but this is part of rollup v2 which is not released.

@iverase iverase merged commit d737369 into elastic:master Oct 27, 2021
@iverase iverase deleted the ByteSizeCachingDirectory branch October 27, 2021 07:32
@iverase
Copy link
Contributor Author

iverase commented Oct 27, 2021

On the other hand this can be an easy win: #79885

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpountz jpountz jpountz approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iverase @elasticmachine @jpountz @jakelandis