Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alias support to fleet search API #79285

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Add alias support to fleet search API #79285

merged 3 commits into from
Oct 15, 2021

Conversation

Tim-Brooks
Copy link
Contributor

Currently the fleet search and msearch APIs do not support aliases. This
PR adds support if the alias resolves to a single concrete index.

@Tim-Brooks
Add alias support to fleet search API
5a5b6ca 
Currently the fleet search and msearch APIs do not support aliases. This
PR adds support if the alias resolves to a single concrete index.
@Tim-Brooks Tim-Brooks added >non-issue :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v8.0.0 v7.16.0 labels Oct 15, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Oct 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

henningandersen
henningandersen approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We need to also update the API docs, which says:

(Required, string) A single index. Index aliases are not supported.

Also rename the index param in the docs to target to be consistent with error messages.

server/src/main/java/org/elasticsearch/action/search/TransportSearchAction.java Outdated
throw new IllegalArgumentException("Index configured with wait_for_checkpoints must be a concrete index resolved in " +
"this search. Index [" + index + "] is not a concrete index resolved in this search.");
throw new IllegalArgumentException("Target configured with wait_for_checkpoints must be a concrete index resolved in " +
"this search. Target [" + target + "] is not a concrete index resolved in this search.");
} else if (indexMetadata == null) {
throw new IllegalArgumentException("Cannot find index configured for wait_for_checkpoints parameter [" + index + "].");
} else if (indexMetadata.getNumberOfShards() != checkpointsProvided) {
throw new IllegalArgumentException("Index configured with wait_for_checkpoints must search the same number of shards as " +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also change to "Target" here?

Suggested change
throw new IllegalArgumentException("Index configured with wait_for_checkpoints must search the same number of shards as " +
throw new IllegalArgumentException("Target configured with wait_for_checkpoints must search the same number of shards as " +

@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Oct 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

sethmlarson
sethmlarson suggested changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation updates are good to leave as-is, one comment about the API specs:

rest-api-spec/src/main/resources/rest-api-spec/api/fleet.search.json Outdated Show resolved Hide resolved
sethmlarson
sethmlarson approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@Tim-Brooks Tim-Brooks merged commit e5c510c into elastic:master Oct 15, 2021
Tim-Brooks added a commit that referenced this pull request Oct 15, 2021
@Tim-Brooks
Add alias support to fleet search API (#79285)
4a9e95b 
Currently the fleet search and msearch APIs do not support aliases. This
PR adds support if the alias resolves to a single concrete index.
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Oct 18, 2021
@weizijun
Merge branch 'upstream/master' into reuse-date-stream-timestamp
c4a4b07 
* upstream/master: (109 commits)
  Migrate custom role providers to licensed feature (elastic#79127)
  Remove stale AwaitsFix in InternalEngineTests (elastic#79323)
  Fix errors in RefreshListenersTests (elastic#79324)
  Reeable BwC Tests after elastic#79318 (elastic#79320)
  Mute BwC Tests for elastic#79318 (elastic#79319)
  Reenable BwC Tests after elastic#79308 (elastic#79313)
  Disable BwC Tests for elastic#79308 (elastic#79310)
  Adjust BWC for node-level field cap requests (elastic#79301)
  Allow total memory to be overridden (elastic#78750)
  Fix SnapshotBasedIndexRecoveryIT#testRecoveryIsCancelledAfterDeletingTheIndex (elastic#79269)
  Disable BWC tests
  Mute GeoIpDownloaderCliIT.testStartWithNoDatabases (elastic#79299)
  Add alias support to fleet search API (elastic#79285)
  Create a coordinating node level reader for tsdb (elastic#79197)
  Route documents to the correct shards in tsdb (elastic#77731)
  Inject migrate action regardless of allocate action (elastic#79090)
  Migrate to data tiers should always ensure a TIER_PREFERENCE is set (elastic#79100)
  Skip building of BWC distributions when building release artifacts (elastic#79180)
  Default ENFORCE_DEFAULT_TIER_PREFERENCE to true (elastic#79275)
  Deprecation of transient cluster settings (elastic#78794)
  ...

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/IndexMode.java
#	server/src/test/java/org/elasticsearch/index/TimeSeriesModeTests.java
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Oct 18, 2021
@weizijun
Merge branch 'upstream/master' into tsdb-deal-timestreamp
e3b7256 
* upstream/master: (521 commits)
  Migrate custom role providers to licensed feature (elastic#79127)
  Remove stale AwaitsFix in InternalEngineTests (elastic#79323)
  Fix errors in RefreshListenersTests (elastic#79324)
  Reeable BwC Tests after elastic#79318 (elastic#79320)
  Mute BwC Tests for elastic#79318 (elastic#79319)
  Reenable BwC Tests after elastic#79308 (elastic#79313)
  Disable BwC Tests for elastic#79308 (elastic#79310)
  Adjust BWC for node-level field cap requests (elastic#79301)
  Allow total memory to be overridden (elastic#78750)
  Fix SnapshotBasedIndexRecoveryIT#testRecoveryIsCancelledAfterDeletingTheIndex (elastic#79269)
  Disable BWC tests
  Mute GeoIpDownloaderCliIT.testStartWithNoDatabases (elastic#79299)
  Add alias support to fleet search API (elastic#79285)
  Create a coordinating node level reader for tsdb (elastic#79197)
  Route documents to the correct shards in tsdb (elastic#77731)
  Inject migrate action regardless of allocate action (elastic#79090)
  Migrate to data tiers should always ensure a TIER_PREFERENCE is set (elastic#79100)
  Skip building of BWC distributions when building release artifacts (elastic#79180)
  Default ENFORCE_DEFAULT_TIER_PREFERENCE to true (elastic#79275)
  Deprecation of transient cluster settings (elastic#78794)
  ...

# Conflicts:
#	rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/10_settings.yml
#	server/src/main/java/org/elasticsearch/common/settings/IndexScopedSettings.java
#	server/src/main/java/org/elasticsearch/common/settings/Setting.java
#	server/src/main/java/org/elasticsearch/index/IndexMode.java
#	server/src/test/java/org/elasticsearch/index/TimeSeriesModeTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

@henningandersen henningandersen henningandersen approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >non-issue Team:Clients Meta label for clients team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.16.0 v8.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tim-Brooks @elasticmachine @sethmlarson @henningandersen @jakelandis