Fix split packages in plugin cli #78027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin CLI was born out of the server jar, to allow the code to be independent, as well as have more isolated tests that use jimfs to test any many filesystem implementations. Yet the cli classes continue to reside in the same package as the plugin service. This commit renames the package in the cli to be cli specific. Most of the change is simple renames and adding imports. A few cases required making plugin service specific classes public. In the future these could be made scoped exports specific to a plugin-cli module, but for now this fix the split packages. Also note the PluginSecurity class was only used by the cli, but is also only tested in the evil-tests, which are run without security manager. Since those will all eventually go away, the test package is also renamed there.
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
@elasticmachine run elasticsearch-ci/part-2 |
💔 Backport failed
You can use sqren/backport to manually backport by running |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Sep 20, 2021
The plugin CLI was born out of the server jar, to allow the code to be independent, as well as have more isolated tests that use jimfs to test any many filesystem implementations. Yet the cli classes continue to reside in the same package as the plugin service. This commit renames the package in the cli to be cli specific. Most of the change is simple renames and adding imports. A few cases required making plugin service specific classes public. In the future these could be made scoped exports specific to a plugin-cli module, but for now this fix the split packages. Also note the PluginSecurity class was only used by the cli, but is also only tested in the evil-tests, which are run without security manager. Since those will all eventually go away, the test package is also renamed there.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 20, 2021
The plugin CLI was born out of the server jar, to allow the code to be independent, as well as have more isolated tests that use jimfs to test any many filesystem implementations. Yet the cli classes continue to reside in the same package as the plugin service. This commit renames the package in the cli to be cli specific. Most of the change is simple renames and adding imports. A few cases required making plugin service specific classes public. In the future these could be made scoped exports specific to a plugin-cli module, but for now this fix the split packages. Also note the PluginSecurity class was only used by the cli, but is also only tested in the evil-tests, which are run without security manager. Since those will all eventually go away, the test package is also renamed there.
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin CLI was born out of the server jar, to allow the code to be
independent, as well as have more isolated tests that use jimfs to test
any many filesystem implementations. Yet the cli classes continue to
reside in the same package as the plugin service. This commit renames
the package in the cli to be cli specific.
Most of the change is simple renames and adding imports. A few cases
required making plugin service specific classes public. In the future
these could be made scoped exports specific to a plugin-cli module, but
for now this fix the split packages. Also note the PluginSecurity class
was only used by the cli, but is also only tested in the evil-tests,
which are run without security manager. Since those will all eventually
go away, the test package is also renamed there.