Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSDB: snapshot/restore test #78022

Merged
merged 8 commits into from
Oct 1, 2021
Merged

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Sep 20, 2021

Adds a basic test for tsdb with snapshot/restore.

@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests v8.0.0 :StorageEngine/TSDB You know, for Metrics v7.16.0 labels Sep 20, 2021
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Sep 20, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Adds a basic test for tsdb with snapshot/restore.

- match: {hits.total.value: 1}
- match: {hits.hits.0._source.k8s.pod.uid: 947e4ced-1786-4e53-9e0c-5c447e959507}
# TODO assert that the _tsid is correct after restore.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to use the same trick I use in #78028 to run an agg on tsid using a runtime field that looks like _tsid just to get the test a little more fleshed out. Just to have something we can look at before _tsid is generated. But, alas, painless isn't available to these tests.

@nik9000 nik9000 requested review from csoulios and imotov September 21, 2021 18:17
Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused. Why do you only put this into hadoop repo and why hadoop?

@nik9000
Copy link
Member Author

nik9000 commented Sep 21, 2021 via email

@nik9000
Copy link
Member Author

nik9000 commented Sep 22, 2021

I put it into Hadoop so I could run it. I can have another look, but I didn't see any shared infrastructure for tests against all repos.

I think it'd be more correct for me to run this with the fs repository in rest-api-spec. It'd be cool to have a thing that runs the same tests against all the repos but I don't think that is a "for now" thing.

@nik9000
Copy link
Member Author

nik9000 commented Sep 22, 2021

@imotov could you have another look?

I've moved this into regular rest-api-tests which seems like the simplest thing. It'd be cool to be able to share snapshot/restore tests with a bunch of repos, but I don't think that is a "for now" problem.

Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think you need to finish the hdfs cleanup though.

@@ -76,7 +76,7 @@ dependencies {

restResources {
restApi {
include '_common', 'cluster', 'nodes', 'indices', 'index', 'snapshot'
include '_common', 'bulk', 'cluster', 'index', 'indices', 'nodes', 'search', 'snapshot'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still necessary?

@nik9000 nik9000 merged commit 9dda447 into elastic:master Oct 1, 2021
@wchaparro wchaparro assigned nik9000 and unassigned nik9000 Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants