Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous HTML start element at end of body #77563

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

ChrisHegarty
Copy link
Contributor

@ChrisHegarty ChrisHegarty commented Sep 10, 2021

In JDK 17, doclint invoked by javac warns of constructs that lead to empty paragraphs in the generated documentation. We have a handful of these, redundant use of <p> at the end of a block of text, which trips up the build. This a preparatory change intended to help smoothen the eventual transition to 17.

The JDK issue that introduced this stricter doclint check in 17 is https://bugs.openjdk.java.net/browse/JDK-8258957.

@ChrisHegarty
Copy link
Contributor Author

ChrisHegarty commented Sep 10, 2021

There is no test for this change, other than compiling with JDK 17 - which completes successfully on "my machine" ;-).

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHegarty ChrisHegarty added >docs General docs changes Team:Core/Infra Meta label for core/infra team labels Sep 10, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Sep 10, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@ChrisHegarty ChrisHegarty removed the >docs General docs changes label Sep 10, 2021
@elasticmachine elasticmachine removed the Team:Docs Meta label for docs team label Sep 10, 2021
@ChrisHegarty ChrisHegarty self-assigned this Sep 10, 2021
@ChrisHegarty ChrisHegarty added auto-backport-and-merge auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Sep 10, 2021
@ChrisHegarty
Copy link
Contributor Author

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit c49f33d into elastic:master Sep 10, 2021
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run backport --upstream elastic/elasticsearch --pr 77563

ChrisHegarty added a commit to ChrisHegarty/elasticsearch that referenced this pull request Sep 11, 2021
elasticsearchmachine pushed a commit that referenced this pull request Sep 13, 2021
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >non-issue Team:Core/Infra Meta label for core/infra team v7.16.0 v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants