Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move vector tile implementation to its own module #73562

Merged
merged 3 commits into from
Jun 2, 2021

Conversation

iverase
Copy link
Contributor

@iverase iverase commented May 31, 2021

This PR moves all new vector tile code into its own pack module called vector-tile. I am removing lots of unused code which was developed as part of the original prototype so the code is looking more similar to the final version. In particular I have removed all the aggregations implementations as we are not using them.

In addition I added a couple of nice things:

  • The API now handles cancellation which it turned to be a big performance booster.
  • The API supports defining a sort field.
  • RestVectorTileAction has been refactor to one class again. I extracted the VectorTileRequest class so it can be unit tested.

@iverase iverase added the :Analytics/Geo Indexing, search aggregations of geo points and shapes label May 31, 2021
@iverase iverase requested a review from imotov May 31, 2021 14:08
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 31, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iverase iverase merged commit 2b27561 into elastic:feature/vector-tiles Jun 2, 2021
@iverase iverase deleted the vector-tile-module branch June 2, 2021 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants