-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make scripting media type parsing more flexible #66857
Conversation
…esponsetype_format_params
Pinging @elastic/es-core-infra (Team:Core/Infra) |
#65500 also accidentally broke the CI by a change in I am however still worrying about the scenario where a cluster is in a mixed state. |
/cc @martijnvg |
@pgomulka The situation you're describing is backwards-incompatible. Unless I'm misunderstanding we need to deprecate the old mime type and replace it with the new one over two versions. If we don't handle this scenario users may get stuck during upgrade when using stored mustache scripts (templates). Edit: Spoke with @pgomulka and it was my misunderstanding. We just need to ensure we only write the older format to nodes that do not support the newer ones as he stated in his previous comment. |
actually do you think it would be easier if we simply deprecate we would only allow |
I am closing this in favour of more simple approach #67677 |
#65500 introduced a change to
content_type
field used in scripting. For JSON it requiredapplication/json; charset=UTF-8
but now the space was removed and lowercase param value is required.This PR is making
content_type
field more flexible. Allowing spaces and is case insensitive for param values.The parsing logic is reusing Content-Type and Accept header parsing
relates #65500
test failure:
closes #66986