A node with roles [ml, remote_cluster_client] is still dedicated ML #66533
Conversation
Where CCS is being used it makes sense for ML nodes to have the remote_cluster_client role. This single extra role is not significant enough to stop an ML node being considered a "dedicated ML node".
|
Pinging @elastic/ml-core (:ml) |
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
|
| @@ -142,7 +142,7 @@ public static MachineNodeRole parse(InputStream config) { | |||
| return MachineNodeRole.DATA; | |||
| } else if (containsOnly(roles, "master")) { | |||
| return MachineNodeRole.MASTER_ONLY; | |||
| } else if (containsOnly(roles, "ml")) { | |||
| } else if (containsOnly(roles, "ml") || containsOnly(roles, "ml", "remote_cluster_client")) { | |||
There was a problem hiding this comment.
This can be simplified to else if (containsOnly(roles, "ml", "remote_cluster_client"). That simply asserts that only the listed roles area llowd to be in the given collection, but a subset is fine as well.
There was a problem hiding this comment.
Thinking now, this would also be true in a case where a node had only the remote_cluster_client role, so maybe we might want to assert roles.contains("ml") && containsOnly(roles, "ml", "remote_cluster_client")
There was a problem hiding this comment.
Thanks. I did that and also added a test to prove remote_cluster_client on its own isn't an ML node.
|
Jenkins run elasticsearch-ci/packaging-windows |
1 similar comment
|
Jenkins run elasticsearch-ci/packaging-windows |
…66533) Where CCS is being used it makes sense for ML nodes to have the remote_cluster_client role. This single extra role is not significant enough to stop an ML node being considered a "dedicated ML node".
…66533) Where CCS is being used it makes sense for ML nodes to have the remote_cluster_client role. This single extra role is not significant enough to stop an ML node being considered a "dedicated ML node".
Where CCS is being used it makes sense for ML nodes to have the
remote_cluster_client role. This single extra role is not
significant enough to stop an ML node being considered a
"dedicated ML node".