[Transform] Do not deduce mappings in latest transform function #66523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ff08a9 to
7d8d9f9
Compare
|
run elasticsearch-ci/2 |
7d8d9f9 to
4302ab8
Compare
4302ab8 to
6e385c3
Compare
|
Pinging @elastic/ml-core (:ml/Transform) |
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Dec 18, 2020
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Dec 18, 2020
przemekwitek
added a commit
that referenced
this pull request
Dec 18, 2020
przemekwitek
added a commit
that referenced
this pull request
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables mapping deduction in case of
latesttransform function. The reason is we cannot deduce the mappings reliably anyway (think of various settings like text's analyzer).In most cases we expect the users providing index templates from which destination index mappings will be taken (the user can even create the destination index with custom mappings at their will).
For the case when there is no template, the transform will still create the destination index, but with no mappings. This will result in documents from source index being indexed into destination index with dynamic mappings.
Additionally, this PR makes
LatestContinuousITtest use runtime fields to verify thatlatesthandles runtime fields correctly.Relates #65869