[ML] Add hyperparameter model metadata #66349

valeriy42 · 2020-12-15T14:26:23Z

This adds hyperparameters section to the stored model metadata document. Here is an example

"hyperparameters": [
        {
            "name": "downsample_factor",
            "value": 0.35355339059327386,
            "supplied": false,
            "absolute_importance": 0.123,
            "relative_importance": 0.9123
        },
        {
            "name": "alpha",
            "value": 0.010766199582740555,
            "supplied": false,
            "absolute_importance": 0.0123,
            "relative_importance": 0.0321
        },
        {
            "name": "gamma",
            "value": 0.1,
            "supplied": true,
            "absolute_importance": 0.0,
            "relative_importance": 0.0
        }
    ]

...va/org/elasticsearch/xpack/core/ml/inference/trainedmodel/metadata/TrainedModelMetadata.java

...g/elasticsearch/xpack/core/ml/inference/trainedmodel/metadata/TrainedModelMetadataTests.java

...gin/ml/src/main/java/org/elasticsearch/xpack/ml/dataframe/process/results/ModelMetadata.java

elasticmachine · 2020-12-18T12:08:38Z

Pinging @elastic/ml-core (:ml)

valeriy42 · 2020-12-18T12:10:31Z

Thank you for your review @benwtrent . I applied your changes. It would be great if you could take another look.

…frame/process/results/ModelMetadata.java Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>

benwtrent · 2020-12-18T12:34:12Z

...in/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/metadata/Hyperparameters.java

+        this.hyperparameterName = hyperparameterName;
+        this.value = value;
+        this.absoluteImportance = absoluteImportance;
+        this.relativeImportance = relativeImportance;
+        this.supplied = supplied;


If the Doubles and the Boolean are truly not nullable, they should be double and boolean (unboxed, not nullable).

If they are nullable, the parser needs to treat them as optional and the serialization needs to as well

...va/org/elasticsearch/xpack/core/ml/inference/trainedmodel/metadata/TrainedModelMetadata.java

…ml/inference/trainedmodel/metadata/TrainedModelMetadata.java Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>

…leriy42/elasticsearch into hyperparameter-model-metadata

...in/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/metadata/Hyperparameters.java

...va/org/elasticsearch/xpack/core/ml/inference/trainedmodel/metadata/HyperparametersTests.java

…ml/inference/trainedmodel/metadata/Hyperparameters.java Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>

…ml/inference/trainedmodel/metadata/HyperparametersTests.java Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>

valeriy42 · 2020-12-18T16:01:54Z

retest

valeriy42 · 2020-12-18T16:02:56Z

recheck

hendrikmuhs · 2020-12-18T16:21:17Z

...plugin/core/src/main/resources/org/elasticsearch/xpack/core/ml/inference_index_template.json

+            },
+            "supplied": {
+              "type": "boolean"
+            },


^ dangling comma

benwtrent · 2020-12-18T17:04:22Z

@elasticmachine update branch

This adds `hyperparameters` section to the stored model metadata document. Here is an example ```json "hyperparameters": [ { "name": "downsample_factor", "value": 0.35355339059327386, "supplied": false, "absolute_importance": 0.123, "relative_importance": 0.9123 }, { "name": "alpha", "value": 0.010766199582740555, "supplied": false, "absolute_importance": 0.0123, "relative_importance": 0.0321 }, { "name": "gamma", "value": 0.1, "supplied": true, "absolute_importance": 0.0, "relative_importance": 0.0 } ] ```

This adds `hyperparameters` section to the stored model metadata document. Here is an example ```json "hyperparameters": [ { "name": "downsample_factor", "value": 0.35355339059327386, "supplied": false, "absolute_importance": 0.123, "relative_importance": 0.9123 }, { "name": "alpha", "value": 0.010766199582740555, "supplied": false, "absolute_importance": 0.0123, "relative_importance": 0.0321 }, { "name": "gamma", "value": 0.1, "supplied": true, "absolute_importance": 0.0, "relative_importance": 0.0 } ] ``` Co-authored-by: Valeriy Khakhutskyy <1292899+valeriy42@users.noreply.github.com>

valeriy42 added 2 commits December 14, 2020 17:35

init commit

d575513

continue adjusting tests

e244d66

valeriy42 added :ml Machine learning >non-issue v7.12.0 v8.0.0 labels Dec 15, 2020

valeriy42 added 3 commits December 15, 2020 17:02

fix ChunkedTrainedModelPersisterIT.java

f6236fb

formatting

48a3645

rename hyperparameters, add supplied

d28b824

benwtrent reviewed Dec 16, 2020

View reviewed changes

valeriy42 marked this pull request as ready for review December 18, 2020 12:08

code review

ff27fab

Update x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/data…

0c8e00b

…frame/process/results/ModelMetadata.java Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>

benwtrent reviewed Dec 18, 2020

View reviewed changes

valeriy42 and others added 6 commits December 18, 2020 13:56

Update x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/…

f73ec7f

…ml/inference/trainedmodel/metadata/TrainedModelMetadata.java Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>

Update x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/…

f301ac7

…ml/inference/trainedmodel/metadata/TrainedModelMetadata.java Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>

optional fields

5515700

Merge branch 'hyperparameter-model-metadata' of https://github.com/va…

b4de908

…leriy42/elasticsearch into hyperparameter-model-metadata

handle optional importance fields

33b8af7

formatting

f14592b

benwtrent reviewed Dec 18, 2020

View reviewed changes

valeriy42 and others added 6 commits December 18, 2020 14:57

Update x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/…

0399e10

…ml/inference/trainedmodel/metadata/Hyperparameters.java Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>

Update x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/…

8be327d

…ml/inference/trainedmodel/metadata/Hyperparameters.java Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>

Update x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/…

be37937

…ml/inference/trainedmodel/metadata/Hyperparameters.java Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>

Update x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/…

f9e6ef2

…ml/inference/trainedmodel/metadata/Hyperparameters.java Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>

Update x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/…

62dab59

…ml/inference/trainedmodel/metadata/HyperparametersTests.java Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>

Update x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/…

3a5182d

…ml/inference/trainedmodel/metadata/HyperparametersTests.java Co-authored-by: Benjamin Trent <ben.w.trent@gmail.com>

benwtrent approved these changes Dec 18, 2020

View reviewed changes

hendrikmuhs reviewed Dec 18, 2020

View reviewed changes

fix dangling comma

cbf0dc8

Merge branch 'master' into hyperparameter-model-metadata

43dbb5b

benwtrent merged commit f136b72 into elastic:master Dec 18, 2020

jakelandis added v8.0.0-alpha1 and removed v8.0.0 labels Jul 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Add hyperparameter model metadata #66349

[ML] Add hyperparameter model metadata #66349

valeriy42 commented Dec 15, 2020 •

edited

Loading

elasticmachine commented Dec 18, 2020

valeriy42 commented Dec 18, 2020

benwtrent Dec 18, 2020

valeriy42 commented Dec 18, 2020

valeriy42 commented Dec 18, 2020

hendrikmuhs Dec 18, 2020

benwtrent commented Dec 18, 2020

[ML] Add hyperparameter model metadata #66349

[ML] Add hyperparameter model metadata #66349

Conversation

valeriy42 commented Dec 15, 2020 • edited Loading

elasticmachine commented Dec 18, 2020

valeriy42 commented Dec 18, 2020

benwtrent Dec 18, 2020

Choose a reason for hiding this comment

valeriy42 commented Dec 18, 2020

valeriy42 commented Dec 18, 2020

hendrikmuhs Dec 18, 2020

Choose a reason for hiding this comment

benwtrent commented Dec 18, 2020

valeriy42 commented Dec 15, 2020 •

edited

Loading