Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize date_histogram's hard_bounds #66051

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Dec 8, 2020

This allows date_histograms with hard_bounds and extended_bounds
to use the "as range" style optimizations introducedin #63643. There
isn't any work to do for exended_bounds besides add a test. For
hard_bounds we have to be careful when constructing the ranges that to
filter.

This allows `date_histogram`s with `hard_bounds` and `extended_bounds`
to use the "as range" style optimizations introducedin elastic#63643. There
isn't any work to do for `exended_bounds` besides add a test. For
`hard_bounds` we have to be careful when constructing the ranges that to
filter.
@nik9000 nik9000 requested a review from imotov December 8, 2020 18:18
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Dec 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@imotov
Copy link
Contributor

imotov commented Dec 8, 2020

There is a typo in the commit title.

@nik9000 nik9000 changed the title Optimize date_historam's hard_bounds Optimize date_histogram's hard_bounds Dec 8, 2020
@nik9000
Copy link
Member Author

nik9000 commented Dec 8, 2020

There is a typo in the commit title.

Thanks!

@nik9000 nik9000 merged commit 57e626e into elastic:master Dec 8, 2020
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Dec 8, 2020
This allows `date_histogram`s with `hard_bounds` and `extended_bounds`
to use the "as range" style optimizations introducedin elastic#63643. There
isn't any work to do for `exended_bounds` besides add a test. For
`hard_bounds` we have to be careful when constructing the ranges that to
filter.
nik9000 added a commit that referenced this pull request Dec 8, 2020
This allows `date_histogram`s with `hard_bounds` and `extended_bounds`
to use the "as range" style optimizations introducedin #63643. There
isn't any work to do for `exended_bounds` besides add a test. For
`hard_bounds` we have to be careful when constructing the ranges that to
filter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.11.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants