Create AllocationDeciders in the main method of the ILM step #65037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-features (Team:Core/Features) |
|
@gaobinlong sorry for the delay on this, I've been on vacation for a while, but I'm back now! |
|
@elasticmachine test this please |
|
@elasticmachine update branch |
|
@elasticmachine test this please |
This was referenced Dec 8, 2020
Merged
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Dec 8, 2020
…#65037) Relates to elastic#64529. Currently the cluster filter variables `clusterRequireFilters` , `clusterIncludeFilters` and `clusterExcludeFilters` are non-static, so the new instance of `FilterAllocationDecider` inited in `SetSingleNodeAllocateStep ` in ILM cannot see the changes when updating the `cluster.routing.allocation.exclude._x` settings, and finally ILM will stuck in the shrink action if one excluded node has been selected in the `SetSingleNodeAllocateStep`. `AllocationRoutedStep` has the same issue. This main changes are: 1. Create `AllocationDeciders ` in the main method of `SetSingleNodeAllocateStep ` and `AllocationRoutedStep`, and the `FilterAllocationDecider ` is constructed using the cluster settings in the cluster metadata, so the cluster level filters can be seen when executing the steps. 2. Add some tests for the change.
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Dec 8, 2020
…#65037) Relates to elastic#64529. Currently the cluster filter variables `clusterRequireFilters` , `clusterIncludeFilters` and `clusterExcludeFilters` are non-static, so the new instance of `FilterAllocationDecider` inited in `SetSingleNodeAllocateStep ` in ILM cannot see the changes when updating the `cluster.routing.allocation.exclude._x` settings, and finally ILM will stuck in the shrink action if one excluded node has been selected in the `SetSingleNodeAllocateStep`. `AllocationRoutedStep` has the same issue. This main changes are: 1. Create `AllocationDeciders ` in the main method of `SetSingleNodeAllocateStep ` and `AllocationRoutedStep`, and the `FilterAllocationDecider ` is constructed using the cluster settings in the cluster metadata, so the cluster level filters can be seen when executing the steps. 2. Add some tests for the change.
dakrone
added a commit
that referenced
this pull request
Dec 8, 2020
dakrone
added a commit
that referenced
this pull request
Dec 8, 2020
dakrone
pushed a commit
that referenced
this pull request
Jan 7, 2021
…67137) Relates to #67133. Seem to #65037. The main changes of this PR are: Modify the construction method of DataTierAllocationDecider, add a param settings like FilterAllocationDecider. Create DataTierAllocationDecider in the main method of DataTierMigrationRoutedStep and SetSingleNodeAllocateStep, and the DataTierAllocationDecider is constructed using the cluster settings in the cluster metadata, so the cluster level _tier filters can be seen when executing the steps. Add some tests for the change.
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Jan 7, 2021
…lastic#67137) Relates to elastic#67133. Seem to elastic#65037. The main changes of this PR are: Modify the construction method of DataTierAllocationDecider, add a param settings like FilterAllocationDecider. Create DataTierAllocationDecider in the main method of DataTierMigrationRoutedStep and SetSingleNodeAllocateStep, and the DataTierAllocationDecider is constructed using the cluster settings in the cluster metadata, so the cluster level _tier filters can be seen when executing the steps. Add some tests for the change.
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Jan 7, 2021
…lastic#67137) Relates to elastic#67133. Seem to elastic#65037. The main changes of this PR are: Modify the construction method of DataTierAllocationDecider, add a param settings like FilterAllocationDecider. Create DataTierAllocationDecider in the main method of DataTierMigrationRoutedStep and SetSingleNodeAllocateStep, and the DataTierAllocationDecider is constructed using the cluster settings in the cluster metadata, so the cluster level _tier filters can be seen when executing the steps. Add some tests for the change.
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Jan 7, 2021
…lastic#67137) Relates to elastic#67133. Seem to elastic#65037. The main changes of this PR are: Modify the construction method of DataTierAllocationDecider, add a param settings like FilterAllocationDecider. Create DataTierAllocationDecider in the main method of DataTierMigrationRoutedStep and SetSingleNodeAllocateStep, and the DataTierAllocationDecider is constructed using the cluster settings in the cluster metadata, so the cluster level _tier filters can be seen when executing the steps. Add some tests for the change.
dakrone
added a commit
that referenced
this pull request
Jan 7, 2021
…ider (#67137) (4295d48) (#67178) Relates to #67133. Seem to #65037. The main changes of this PR are: Modify the construction method of DataTierAllocationDecider, add a param settings like FilterAllocationDecider. Create DataTierAllocationDecider in the main method of DataTierMigrationRoutedStep and SetSingleNodeAllocateStep, and the DataTierAllocationDecider is constructed using the cluster settings in the cluster metadata, so the cluster level _tier filters can be seen when executing the steps. Add some tests for the change. Co-authored-by: bellengao <gbl_long@163.com>
dakrone
added a commit
that referenced
this pull request
Jan 7, 2021
…der (#67137) (4295d48) (#67177) Relates to #67133. Seem to #65037. The main changes of this PR are: Modify the construction method of DataTierAllocationDecider, add a param settings like FilterAllocationDecider. Create DataTierAllocationDecider in the main method of DataTierMigrationRoutedStep and SetSingleNodeAllocateStep, and the DataTierAllocationDecider is constructed using the cluster settings in the cluster metadata, so the cluster level _tier filters can be seen when executing the steps. Add some tests for the change. Co-authored-by: bellengao <gbl_long@163.com>
dakrone
added a commit
that referenced
this pull request
Jan 7, 2021
…ider (#67137) (4295d48) (#67180) Relates to #67133. Seem to #65037. The main changes of this PR are: Modify the construction method of DataTierAllocationDecider, add a param settings like FilterAllocationDecider. Create DataTierAllocationDecider in the main method of DataTierMigrationRoutedStep and SetSingleNodeAllocateStep, and the DataTierAllocationDecider is constructed using the cluster settings in the cluster metadata, so the cluster level _tier filters can be seen when executing the steps. Add some tests for the change. Co-authored-by: bellengao <gbl_long@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #64529.
Currently the cluster filter variables
clusterRequireFilters,clusterIncludeFiltersandclusterExcludeFiltersare non-static, so the new instance ofFilterAllocationDeciderinited inSetSingleNodeAllocateStepin ILM cannot see the changes when updating thecluster.routing.allocation.exclude._xsettings, and finally ILM will stuck in the shrink action if one excluded node has been selected in theSetSingleNodeAllocateStep.AllocationRoutedStephas the same issue.This main changes are:
AllocationDecidersin the main method ofSetSingleNodeAllocateStepandAllocationRoutedStep, and theFilterAllocationDecideris constructed using the cluster settings in the cluster metadata, so the cluster level filters can be seen when executing the steps.