Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Data stream migration API #65017

Merged
merged 8 commits into from
Nov 16, 2020
Merged

[DOCS] Data stream migration API #65017

merged 8 commits into from
Nov 16, 2020

Conversation

danhermann
Copy link
Contributor

This is the final PR for #61046.

@danhermann danhermann added >docs General docs changes v8.0.0 :Data Management/Data streams Data streams and their lifecycles v7.11.0 labels Nov 12, 2020
@danhermann danhermann requested a review from jrodewig November 12, 2020 19:55
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Data streams)

@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Data Management Meta label for data/management team labels Nov 12, 2020
jrodewig
jrodewig approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I made some suggestions, but feel free to ignore those if wanted. I'm good with shipping this as is. Thanks @danhermann!

docs/reference/indices/migrate-to-data-stream.asciidoc Outdated Show resolved Hide resolved
docs/reference/indices/migrate-to-data-stream.asciidoc Outdated Show resolved Hide resolved
danhermann and others added 2 commits November 13, 2020 07:49
@danhermann @jrodewig
Update docs/reference/indices/migrate-to-data-stream.asciidoc
2569349 
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
@danhermann @jrodewig
Update docs/reference/indices/migrate-to-data-stream.asciidoc
4c07203 
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
@danhermann
Copy link
Contributor Author

@elasticmachine update branch

martijnvg
martijnvg approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danhermann danhermann merged commit 0a2891e into elastic:master Nov 16, 2020
@danhermann danhermann deleted the 61046_docs2 branch November 16, 2020 13:51
@danhermann danhermann mentioned this pull request Nov 18, 2020
Closed
This was referenced Dec 7, 2020
Merged
Merged
This was referenced Dec 23, 2020
Merged
Merged
@jrodewig
Copy link
Contributor

Went ahead and backported this with #66786 (7.x) and #66787 (7.11). That'll let me get backports of #66054 in as well.

jrodewig added a commit that referenced this pull request Dec 23, 2020
@jrodewig @danhermann
[DOCS] Data stream migration API (#65017) (#66786)
83eabfc 
Co-authored-by: Dan Hermann <danhermann@users.noreply.github.com>
jrodewig added a commit that referenced this pull request Dec 23, 2020
@jrodewig @danhermann
[DOCS] Data stream migration API (#65017) (#66787)
bc08ede 
Co-authored-by: Dan Hermann <danhermann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnvg martijnvg martijnvg approved these changes

@jrodewig jrodewig jrodewig approved these changes

Assignees
No one assigned
Labels
:Data Management/Data streams Data streams and their lifecycles >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.11.0 v7.12.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danhermann @elasticmachine @jrodewig @martijnvg @jakelandis