Search - make term/prefix/wildcard/regex query parsing more lenient #63926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-search (:Search/Search) |
| @@ -109,9 +109,6 @@ public String value() { | |||
| } | |||
|
|
|||
| public PrefixQueryBuilder caseInsensitive(boolean caseInsensitive) { | |||
| if (caseInsensitive == false) { | |||
| throw new IllegalArgumentException("The case insensitive setting cannot be set to false."); | |||
| } | |||
There was a problem hiding this comment.
What's the plan here? To allow clients to set caseInsensitive to false?
There was a problem hiding this comment.
Yep. Makes some of the clients easier to write
5d4af4f to
87423ee
Compare
|
test this please |
markharwood
added a commit
to markharwood/elasticsearch
that referenced
this pull request
Oct 21, 2020
…lastic#63926) * Remove errors when case_insensitive flag set to false Closes elastic#63893
markharwood
added a commit
to markharwood/elasticsearch
that referenced
this pull request
Oct 21, 2020
…lastic#63926) * Remove errors when case_insensitive flag set to false Closes elastic#63893
markharwood
added a commit
that referenced
this pull request
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove errors when case_insensitive flag set to false
Closes #63893