Adding script support for version parts #62953
Conversation
|
Thanks @cbuescher. This change LGTM! Also you mentioned that it is one potential solution. What's another? Is it indexing these fields explicitly? |
That would be one other option, also using runtime fields for this comes into mind, which would potentially be slower but would allow the same kind of operations for versions currently stored in ' keyword' fields I think. I think this can be discussed in #62952 before proceeding but thanks for the review. |
| @@ -55,4 +56,63 @@ public String get(int index) { | |||
| public int size() { | |||
| return count; | |||
| } | |||
|
|
|||
| public boolean isValid() { | |||
There was a problem hiding this comment.
VersionScriptDocValues is a list so I don't think this is the right level to apply the functions. We accept multiple values so there should be a way to apply these functions to the first, second or last entry in the list too ?
These functions could also be applied to any string (keyword family) field ? A static function likesemverIsRelease(String) that would work on the decoded version could also be helpful imo, we don't need to put these functions under the new script values.
|
This PR is hopelessly outdated, so closing it. |
Spin off of #59773 that factors out adding support to access special information about a version field value via scripts.
This is only one potential solution, so mainly opening this for discussion.