DOC Mapping updates are deprecated for ingestion privileges #60024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodewig
approved these changes
Jul 22, 2020
Co-authored-by: James Rodewig <james.rodewig@elastic.co>
Co-authored-by: James Rodewig <james.rodewig@elastic.co>
Co-authored-by: James Rodewig <james.rodewig@elastic.co>
Co-authored-by: James Rodewig <james.rodewig@elastic.co>
Co-authored-by: James Rodewig <james.rodewig@elastic.co>
|
Thank you @jrodewig ! I like your revised phrasing much more, very good! |
tvernum
approved these changes
Jul 23, 2020
Co-authored-by: Tim Vernum <tim@adjective.org>
albertzaharovits
added a commit
that referenced
this pull request
Jul 23, 2020
This PR contains the deprecation notice that `create`, `create_doc`, `index` and `write` ingest privileges do not permit mapping updates in version 8. It also updates the docs description of said privileges. This should've been part of #58784
This was referenced Mar 31, 2022
albertzaharovits
added a commit
that referenced
this pull request
May 11, 2022
…85570) We missed, in v8.0, to actually break the deprecated behavior from #60024 . Consequently, the deprecated behavior still works in all 8.* and it still generates deprecation logs and headers. This PR reinstates the doc side of the deprecation notice, the plan being that we're now going to break the behavior in v9. Co-authored-by: Adam Locke <adam.locke@elastic.co>
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
May 11, 2022
…lastic#85570) We missed, in v8.0, to actually break the deprecated behavior from elastic#60024 . Consequently, the deprecated behavior still works in all 8.* and it still generates deprecation logs and headers. This PR reinstates the doc side of the deprecation notice, the plan being that we're now going to break the behavior in v9. Co-authored-by: Adam Locke <adam.locke@elastic.co>
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
May 11, 2022
…lastic#85570) We missed, in v8.0, to actually break the deprecated behavior from elastic#60024 . Consequently, the deprecated behavior still works in all 8.* and it still generates deprecation logs and headers. This PR reinstates the doc side of the deprecation notice, the plan being that we're now going to break the behavior in v9. Co-authored-by: Adam Locke <adam.locke@elastic.co>
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
May 11, 2022
…lastic#85570) We missed, in v8.0, to actually break the deprecated behavior from elastic#60024 . Consequently, the deprecated behavior still works in all 8.* and it still generates deprecation logs and headers. This PR reinstates the doc side of the deprecation notice, the plan being that we're now going to break the behavior in v9. Co-authored-by: Adam Locke <adam.locke@elastic.co>
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 11, 2022
…85570) (#86698) We missed, in v8.0, to actually break the deprecated behavior from #60024 . Consequently, the deprecated behavior still works in all 8.* and it still generates deprecation logs and headers. This PR reinstates the doc side of the deprecation notice, the plan being that we're now going to break the behavior in v9. Co-authored-by: Adam Locke <adam.locke@elastic.co> Co-authored-by: Adam Locke <adam.locke@elastic.co>
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 11, 2022
…85570) (#86699) We missed, in v8.0, to actually break the deprecated behavior from #60024 . Consequently, the deprecated behavior still works in all 8.* and it still generates deprecation logs and headers. This PR reinstates the doc side of the deprecation notice, the plan being that we're now going to break the behavior in v9. Co-authored-by: Adam Locke <adam.locke@elastic.co> Co-authored-by: Adam Locke <adam.locke@elastic.co>
albertzaharovits
added a commit
that referenced
this pull request
May 11, 2022
…85570) We missed, in v8.0, to actually break the deprecated behavior from #60024 . Consequently, the deprecated behavior still works in all 8.* and it still generates deprecation logs and headers. This PR reinstates the doc side of the deprecation notice, the plan being that we're now going to break the behavior in v9. Co-authored-by: Adam Locke <adam.locke@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've forgot to adjust the docs and the migration notice following #58784 .
The text describes the deprecated behaviour in the next subsequent minor releases, which then turns into breaking behaviour in version 8, but the code (and the accompanying notice) that it refers to, is still due. I will raise that PR promptly.