Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add data streams to API conventions #58695

Merged
merged 5 commits into from
Jun 30, 2020
Merged

[DOCS] Add data streams to API conventions #58695

merged 5 commits into from
Jun 30, 2020

Conversation

jrodewig
Copy link
Contributor

Updates the existing API conventions docs to make them aware of data
streams.

@jrodewig
[DOCS] Add data streams to API conventions
9d0796b 
Updates the existing API conventions docs to make them aware of data
streams.
@jrodewig jrodewig mentioned this pull request Jun 29, 2020
Closed
76 tasks
@jrodewig jrodewig marked this pull request as ready for review June 30, 2020 17:43
@jrodewig jrodewig added :Data Management/Data streams Data streams and their lifecycles >docs General docs changes v7.9.0 v8.0.0 labels Jun 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Data streams)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jun 30, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jun 30, 2020
debadair
debadair approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few editorial suggestions but LGTM

docs/reference/api-conventions.asciidoc Outdated Show resolved Hide resolved
docs/reference/api-conventions.asciidoc Outdated Show resolved Hide resolved
docs/reference/api-conventions.asciidoc Outdated Show resolved Hide resolved
docs/reference/api-conventions.asciidoc Outdated Show resolved Hide resolved
lockewritesdocs
lockewritesdocs approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some editorial changes, but 👍 otherwise.

docs/reference/snapshot-restore/take-snapshot.asciidoc Show resolved Hide resolved
docs/reference/snapshot-restore/take-snapshot.asciidoc Show resolved Hide resolved
@jrodewig @debadair
Apply suggestions from code review
06c6972 
Co-authored-by: debadair <debadair@elastic.co>
@jrodewig jrodewig merged commit 483bab2 into elastic:master Jun 30, 2020
@jrodewig jrodewig deleted the docs__ds-api-conventions branch June 30, 2020 21:06
@jrodewig jrodewig mentioned this pull request Jun 30, 2020
Merged
jrodewig added a commit that referenced this pull request Jun 30, 2020
@jrodewig @debadair
[DOCS] Add data streams to API conventions (#58695) (#58785)
3aa08fb 
Updates the existing API conventions docs to make them aware of data
streams.

Co-authored-by: debadair <debadair@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danhermann danhermann danhermann left review comments

@lockewritesdocs lockewritesdocs lockewritesdocs approved these changes

@debadair debadair debadair approved these changes

Assignees
No one assigned
Labels
:Data Management/Data streams Data streams and their lifecycles >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.9.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jrodewig @elasticmachine @debadair @danhermann @lockewritesdocs @jakelandis