[ML] Anomaly detection jobs should allow missing values for geo fields #57300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
droberts195
reviewed
May 28, 2020
| @@ -24,9 +24,13 @@ public GeoPointField(String name) { | |||
| @Override | |||
| public Object[] value(SearchHit hit) { | |||
| Object[] value = super.value(hit); | |||
| if (value.length != 1) { | |||
| if (value.length == 0) { | |||
| return new Object[0]; | |||
There was a problem hiding this comment.
Theoretically it would save a memory allocation and garbage collection to just return value;. Maybe Hotspot will optimise this in practice.
Same in the other file.
Allows geo fields (`geo_point`, `geo_shape`) to have missing values. Fixes a bug where such missing values would result in an error. Closes elastic#57299
31296ca to
50ff241
Compare
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
May 29, 2020
…fields (elastic#57300) Allows geo fields (`geo_point`, `geo_shape`) to have missing values. Fixes a bug where such missing values would result in an error. Closes elastic#57299 Backport of elastic#57300
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
May 29, 2020
…fields (elastic#57300) Allows geo fields (`geo_point`, `geo_shape`) to have missing values. Fixes a bug where such missing values would result in an error. Closes elastic#57299 Backport of elastic#57300
dimitris-athanasiou
added a commit
that referenced
this pull request
May 29, 2020
dimitris-athanasiou
added a commit
that referenced
this pull request
May 29, 2020
dimitris-athanasiou
added a commit
that referenced
this pull request
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows geo fields (
geo_point,geo_shape) to have missing values.Fixes a bug where such missing values would result in an error.
Closes #57299