Fix NormalizerAgg test searcher wrapping #57171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The searcher was randomly wrapping its reader as slow, parallel, or filtered. This was causing casting issues in the normalizer tests. By removing the wrapping, the problem goes away. Closes elastic#57164
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
nik9000
reviewed
May 26, 2020
...tics/src/test/java/org/elasticsearch/xpack/analytics/normalize/NormalizeAggregatorTests.java
Show resolved
Hide resolved
nik9000
approved these changes
May 26, 2020
There was a problem hiding this comment.
LGTM.
If you mean boolean maybeWrap = unwrapped == indexReader; from AggregatorTestCase, I'm removing it now. It prevented us from using lucene's wrappers when we needed global ordinals. But now that we're using newIndexSearcher we won't use the wrapper anyway.
talevy
added a commit
that referenced
this pull request
May 26, 2020
The searcher was randomly wrapping its reader as slow, parallel, or filtered. This was causing casting issues in the normalizer tests. By removing the wrapping, the problem goes away. Closes #57164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The searcher was randomly wrapping its reader as slow, parallel, or filtered.
This was causing casting issues in the normalizer tests. By removing the
wrapping, the problem goes away.
Closes #57164