-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom metadata tool #50813
Remove custom metadata tool #50813
Conversation
@elasticmachine run elasticsearch-ci/2 |
Pinging @elastic/es-distributed (:Distributed/Cluster Coordination) |
d2000bb
to
119a4a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some comments/questions on UX & docs but nothing major.
server/src/main/java/org/elasticsearch/cluster/coordination/RemoveCustomsCommand.java
Show resolved
Hide resolved
Co-Authored-By: David Turner <david.turner@elastic.co>
Bad interaction with other recently merged PR.
Adds a command-line tool to remove broken custom metadata from the cluster state. Relates to #48701
Hi, only a minor remark related to the title of this PR as well as in #50694 both of which appear in blog notes (https://www.elastic.co/blog/this-week-in-elasticsearch-and-apache-lucene-2020-01-17), I find them ambiguous and would find a naming like below better:
Anyway, thanks for that! |
Adds a command-line tool to remove broken custom metadata from the cluster state. Relates to elastic#48701
Bad interaction with other recently merged PR.
Adds a command-line tool to remove broken custom metadata from the cluster state.
Relates to #48701