-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard against null geoBoundingBox #50506
Guard against null geoBoundingBox #50506
Conversation
A geo box with a top value of Double.NEGATIVE_INFINITY will yield an empty xContent which translates to a null `geoBoundingBox`. This commit marks the field as `Nullable` and guards against null when retrieving the `topLeft` and `bottomRight` fields. Fixes elastic#50505
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice catch!
A geo box with a top value of Double.NEGATIVE_INFINITY will yield an empty xContent which translates to a null `geoBoundingBox`. This commit marks the field as `Nullable` and guards against null when retrieving the `topLeft` and `bottomRight` fields. Fixes elastic#50505 (cherry picked from commit 051718f) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
A geo box with a top value of Double.NEGATIVE_INFINITY will yield an empty xContent which translates to a null `geoBoundingBox`. This commit marks the field as `Nullable` and guards against null when retrieving the `topLeft` and `bottomRight` fields. Fixes #50505 (cherry picked from commit 051718f) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
A geo box with a top value of Double.NEGATIVE_INFINITY will yield an empty xContent which translates to a null `geoBoundingBox`. This commit marks the field as `Nullable` and guards against null when retrieving the `topLeft` and `bottomRight` fields. Fixes elastic#50505
The backport PR seems to have been merged. I'm therefore removing the backport pending label here. Please shout if this is incorrect |
A geo box with a top value of Double.NEGATIVE_INFINITY will yield an empty
xContent which translates to a null
geoBoundingBox
. This commit marks thefield as
Nullable
and guards against null when retrieving thetopLeft
and
bottomRight
fields.Fixes #50505