[Transform] improve error handling of script errors #48887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml/Transform) |
4a37804 to
13dd1f3
Compare
|
run elasticsearch-ci/packaging-sample-matrix |
benwtrent
reviewed
Nov 13, 2019
| * @param e raw Exception | ||
| * @return unwrapped elasticsearch exception | ||
| */ | ||
| public static ElasticsearchException getRootCauseElasticsearchException(Exception e) { |
There was a problem hiding this comment.
Why didn't you put this in the transforms ExceptionHelper class?
There was a problem hiding this comment.
ExceptionHelper is used to validate input parameters, so it serves a different purpose. In the long run this generic class should move into core.
The root cause finder has a different purpose and probably can not be generalized.
...rm/src/main/java/org/elasticsearch/xpack/transform/utils/SearchExceptionRootCauseFinder.java
Outdated
Show resolved
Hide resolved
...n/transform/src/main/java/org/elasticsearch/xpack/transform/transforms/TransformIndexer.java
Outdated
Show resolved
Hide resolved
|
Thanks @benwtrent for the review! Good points, I addressed your remarks and pushed an update. |
benwtrent
approved these changes
Nov 15, 2019
|
run elasticsearch-ci/bwc |
5785a62 to
68e3af0
Compare
|
run elasticsearch-ci/packaging-sample-matrix |
1 similar comment
|
run elasticsearch-ci/packaging-sample-matrix |
hendrikmuhs
pushed a commit
that referenced
this pull request
Nov 18, 2019
improve error handling for script errors, treating it as irrecoverable errors which puts the task immediately into failed state, also improves the error extraction to properly report the script error. fixes #48467
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve error handling for script errors, treating it as irrecoverable errors which puts the task
immediately into failed state, also improves the error extraction to properly report the script error.
fixes #48467