[Transform] rename data frame transform to transform for hlrc client #46933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
ee0d428 to
01d1154
Compare
4cab2ad to
3618694
Compare
|
run elasticsearch-ci/docs-check |
benwtrent
approved these changes
Sep 24, 2019
| private int count; | ||
| private InvalidTransforms invalidTransforms; | ||
|
|
||
| public GetDataFrameTransformResponse(List<DataFrameTransformConfig> transformConfigurations, | ||
| public GetTransformResponse(List<TransformConfig> transformConfigurations, | ||
| int count, |
There was a problem hiding this comment.
#nit indention fix.
Suggested change
| int count, | |
| int count, |
| private int count; | ||
| private InvalidTransforms invalidTransforms; | ||
|
|
||
| public GetDataFrameTransformResponse(List<DataFrameTransformConfig> transformConfigurations, | ||
| public GetTransformResponse(List<TransformConfig> transformConfigurations, | ||
| int count, | ||
| @Nullable InvalidTransforms invalidTransforms) { |
There was a problem hiding this comment.
Suggested change
| @Nullable InvalidTransforms invalidTransforms) { | |
| @Nullable InvalidTransforms invalidTransforms) { |
| return PARSER.parse(parser, null); | ||
| } | ||
|
|
||
| public StartDataFrameTransformResponse(boolean acknowledged, @Nullable List<TaskOperationFailure> taskFailures, | ||
| public StartTransformResponse(boolean acknowledged, @Nullable List<TaskOperationFailure> taskFailures, | ||
| @Nullable List<? extends ElasticsearchException> nodeFailures) { |
There was a problem hiding this comment.
Suggested change
| @Nullable List<? extends ElasticsearchException> nodeFailures) { | |
| @Nullable List<? extends ElasticsearchException> nodeFailures) { |
| return PARSER.parse(parser, null); | ||
| } | ||
|
|
||
| public StopDataFrameTransformResponse(boolean acknowledged, @Nullable List<TaskOperationFailure> taskFailures, | ||
| public StopTransformResponse(boolean acknowledged, @Nullable List<TaskOperationFailure> taskFailures, | ||
| @Nullable List<? extends ElasticsearchException> nodeFailures) { |
There was a problem hiding this comment.
Suggested change
| @Nullable List<? extends ElasticsearchException> nodeFailures) { | |
| @Nullable List<? extends ElasticsearchException> nodeFailures) { |
| public DataFrameTransformCheckpointStats(final long checkpoint, final DataFrameIndexerPosition position, | ||
| final DataFrameTransformProgress checkpointProgress, final long timestampMillis, | ||
| public TransformCheckpointStats(final long checkpoint, final TransformIndexerPosition position, | ||
| final TransformProgress checkpointProgress, final long timestampMillis, |
There was a problem hiding this comment.
Suggested change
| final TransformProgress checkpointProgress, final long timestampMillis, | |
| final TransformProgress checkpointProgress, final long timestampMillis, |
| Map<String, SingleGroupSource> groups, | ||
| AggregatorFactories.Builder aggregations, | ||
| String destinationIndex, | ||
| String... sourceIndices) throws Exception { | ||
| return createTransformConfig(id, groups, aggregations, destinationIndex, QueryBuilders.matchAllQuery(), sourceIndices); | ||
| } | ||
|
|
||
| protected DataFrameTransformConfig.Builder createTransformConfigBuilder(String id, | ||
| protected TransformConfig.Builder createTransformConfigBuilder(String id, | ||
| Map<String, SingleGroupSource> groups, | ||
| AggregatorFactories.Builder aggregations, |
There was a problem hiding this comment.
Suggested change
| AggregatorFactories.Builder aggregations, | |
| AggregatorFactories.Builder aggregations, |
| Map<String, SingleGroupSource> groups, | ||
| AggregatorFactories.Builder aggregations, | ||
| String destinationIndex, | ||
| String... sourceIndices) throws Exception { | ||
| return createTransformConfig(id, groups, aggregations, destinationIndex, QueryBuilders.matchAllQuery(), sourceIndices); | ||
| } | ||
|
|
||
| protected DataFrameTransformConfig.Builder createTransformConfigBuilder(String id, | ||
| protected TransformConfig.Builder createTransformConfigBuilder(String id, | ||
| Map<String, SingleGroupSource> groups, | ||
| AggregatorFactories.Builder aggregations, | ||
| String destinationIndex, |
There was a problem hiding this comment.
Suggested change
| String destinationIndex, | |
| String destinationIndex, |
| Map<String, SingleGroupSource> groups, | ||
| AggregatorFactories.Builder aggregations, | ||
| String destinationIndex, | ||
| String... sourceIndices) throws Exception { | ||
| return createTransformConfig(id, groups, aggregations, destinationIndex, QueryBuilders.matchAllQuery(), sourceIndices); | ||
| } | ||
|
|
||
| protected DataFrameTransformConfig.Builder createTransformConfigBuilder(String id, | ||
| protected TransformConfig.Builder createTransformConfigBuilder(String id, | ||
| Map<String, SingleGroupSource> groups, | ||
| AggregatorFactories.Builder aggregations, | ||
| String destinationIndex, | ||
| QueryBuilder queryBuilder, |
There was a problem hiding this comment.
Suggested change
| QueryBuilder queryBuilder, | |
| QueryBuilder queryBuilder, |
| Map<String, SingleGroupSource> groups, | ||
| AggregatorFactories.Builder aggregations, | ||
| String destinationIndex, | ||
| String... sourceIndices) throws Exception { | ||
| return createTransformConfig(id, groups, aggregations, destinationIndex, QueryBuilders.matchAllQuery(), sourceIndices); | ||
| } | ||
|
|
||
| protected DataFrameTransformConfig.Builder createTransformConfigBuilder(String id, | ||
| protected TransformConfig.Builder createTransformConfigBuilder(String id, | ||
| Map<String, SingleGroupSource> groups, | ||
| AggregatorFactories.Builder aggregations, | ||
| String destinationIndex, | ||
| QueryBuilder queryBuilder, | ||
| String... sourceIndices) throws Exception { |
There was a problem hiding this comment.
Suggested change
| String... sourceIndices) throws Exception { | |
| String... sourceIndices) throws Exception { |
| @@ -218,7 +218,7 @@ protected DataFrameTransformConfig createTransformConfig(String id, | |||
| .setDescription("Test transform config id: " + id); | |||
| } | |||
|
|
|||
| protected DataFrameTransformConfig createTransformConfig(String id, | |||
| protected TransformConfig createTransformConfig(String id, | |||
|
run elasticsearch-ci/bwc |
hendrikmuhs
pushed a commit
that referenced
this pull request
Sep 25, 2019
…46933) rename data frame transform to transform for hlrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename data frame transform to transform for hlrc