Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Use versions file from elastic/docs #46719

Merged
merged 5 commits into from
Sep 18, 2019
Merged

[DOCS] Use versions file from elastic/docs #46719

merged 5 commits into from
Sep 18, 2019

Conversation

jrodewig
Copy link
Contributor

Replaces several attributes in $ES_REPO_ROOT/doc/Versions.asciidoc file with a stack version file.

This will reduce work effort during docs releases and decrease the likelihood of update errors.

Closes #46687.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@jrodewig
Copy link
Contributor Author

@elasticmachine update branch

@jrodewig
Copy link
Contributor Author

jrodewig commented Sep 16, 2019

Blocked by elastic/stack-docs#512

@jrodewig
Copy link
Contributor Author

@elasticmachine update branch

@jrodewig jrodewig requested review from nik9000 and debadair and removed request for nik9000 September 16, 2019 15:15
@jrodewig jrodewig marked this pull request as ready for review September 16, 2019 15:15
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Fine by me but I imagine there are others who'll want to weigh in too.

@debadair
Copy link
Contributor

Rather than updating the includes in every index file, I think we should include the shared versions file from Versions.asciidoc like we do for the shared attributes.

@jrodewig
Copy link
Contributor Author

Thanks @debadair. I went with that approach. Related commits are 75c5aab and addf884.

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit cdee0ea into elastic:master Sep 18, 2019
@jrodewig jrodewig deleted the use-stack-doc-versions branch September 18, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Use shared "stack" version file in elastic/docs for docs version bumps
5 participants