[DOCS] mention automatic cancellation in search docs #46706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-search |
|
Pinging @elastic/es-docs |
jimczi
reviewed
Sep 13, 2019
docs/reference/search.asciidoc
Outdated
| in from gets closed. It is fundamental that the http client sending requests | ||
| closes connections whenever requests time out or are aborted. Automatic | ||
| cancellation relies on standard <<task-cancellation,task cancellation>> | ||
| mechanism. By default, a running search only checks if it is cancelled or not |
There was a problem hiding this comment.
This is unrelated to this change but the default value for low_level_cancellation is now true so the doc is not accurate. We should remove this sentence entirely: By default, a running search only checks if it is cancelled or not....
docs/reference/search.asciidoc
Outdated
| Searches can be cancelled using standard <<task-cancellation,task cancellation>> | ||
| mechanism. By default, a running search only checks if it is cancelled or | ||
| not on segment boundaries, therefore the cancellation can be delayed by large | ||
| Searches are automatically cancelled when the http connection that they came |
There was a problem hiding this comment.
I find the sentence hard to read, maybe something like: when the http connection used to perform the request is closed by the client ?
|
@jimczi can you have another look? |
giladgal
approved these changes
Sep 13, 2019
javanna
added a commit
that referenced
this pull request
Sep 19, 2019
javanna
added a commit
that referenced
this pull request
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a small note around automatic search cancellation which was missed as part of #43332
Relates to #43332