Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Stale Root Level Blobs in Sn. Repository (#43542) #44226

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Cleanup Stale Root Level Blobs in Sn. Repository (#43542) #44226

merged 1 commit into from
Jul 11, 2019

Conversation

original-brownbear
Copy link
Member

  • Cleans up all root level temp., snap-%s.dat, meta-%s.dat blobs that aren't referenced by any snapshot to deal with dangling blobs left behind by delete and snapshot finalization failures
    • The scenario that get's us here is a snapshot failing before it was finalized or a delete failing right after it wrote the updated index-(N+1) that doesn't reference a snapshot anymore but then fails to remove that snapshot
    • Not deleting other dangling blobs since that don't follow the snap-, meta- or tempfile naming schemes to not accidentally delete blobs not created by the snapshot logic
  • Follow up to Recursively Delete Unreferenced Index Directories #42189
    • Same safety logic, get list of all blobs before writing index-N blobs, delete things after index-N blobs was written

backport of #43542

@original-brownbear
Cleanup Stale Root Level Blobs in Sn. Repository (elastic#43542)
d517896 
* Cleans up all root level temp., snap-%s.dat, meta-%s.dat blobs that aren't referenced by any snapshot to deal with dangling blobs left behind by delete and snapshot finalization failures
   * The scenario that get's us here is a snapshot failing before it was finalized or a delete failing right after it wrote the updated index-(N+1) that doesn't reference a snapshot anymore but then fails to remove that snapshot
   * Not deleting other dangling blobs since that don't follow the snap-, meta- or tempfile naming schemes to not accidentally delete blobs not created by the snapshot logic
* Follow up to elastic#42189
  * Same safety logic, get list of all blobs before writing index-N blobs, delete things after index-N blobs was written
@original-brownbear
Copy link
Member Author

Jenkins run elasticsearch-ci/1

1 similar comment
@original-brownbear
Copy link
Member Author

Jenkins run elasticsearch-ci/1

@original-brownbear original-brownbear merged commit 2768662 into elastic:7.x Jul 11, 2019
@original-brownbear original-brownbear deleted the 43542-7.x branch July 11, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@original-brownbear