[DOCS] Allow attribute substitution in titleabbrevs for Asciidoctor migration #41574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-docs |
|
I believe you can also enable [subs="attributes"] on the +++ snippets.
Either way is fine with me.
…On Fri, Apr 26, 2019, 08:30 James Rodewig ***@***.***> wrote:
Asciidoctor does not expand attributes included in <titleabbrev> tags.
This replaces those attributes in preparation for the Asciidoctor migration.
Relates to /elastic/docs/#827
<#827> and #41128
<#41128>.
------------------------------
You can view, comment on, or merge this pull request online at:
#41574
Commit Summary
- [DOCS] Replace attributes in titleabbrevs for Asciidoctor migration
File Changes
- *M* docs/reference/data-frames/apis/delete-transform.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-0> (4)
- *M* docs/reference/data-frames/apis/get-transform-stats.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-1> (4)
- *M* docs/reference/data-frames/apis/get-transform.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-2> (4)
- *M* docs/reference/data-frames/apis/preview-transform.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-3> (4)
- *M* docs/reference/data-frames/apis/put-transform.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-4> (4)
- *M* docs/reference/data-frames/apis/start-transform.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-5> (4)
- *M* docs/reference/data-frames/apis/stop-transform.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-6> (4)
- *M* docs/reference/ilm/apis/get-status.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-7> (4)
- *M* docs/reference/ilm/apis/start.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-8> (4)
- *M* docs/reference/ilm/apis/stop.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-9> (4)
- *M* docs/reference/ml/apis/delete-datafeed.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-10>
(4)
- *M* docs/reference/ml/apis/get-datafeed-stats.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-11>
(4)
- *M* docs/reference/ml/apis/get-datafeed.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-12>
(4)
- *M* docs/reference/ml/apis/get-ml-info.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-13>
(2)
- *M* docs/reference/ml/apis/preview-datafeed.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-14>
(4)
- *M* docs/reference/ml/apis/put-datafeed.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-15>
(4)
- *M* docs/reference/ml/apis/start-datafeed.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-16>
(4)
- *M* docs/reference/ml/apis/stop-datafeed.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-17>
(4)
- *M* docs/reference/ml/apis/update-datafeed.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-18>
(4)
- *M* docs/reference/monitoring/configuring-metricbeat.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-19>
(4)
- *M* docs/reference/settings/notification-settings.asciidoc
<https://github.com/elastic/elasticsearch/pull/41574/files#diff-20>
(4)
Patch Links:
- https://github.com/elastic/elasticsearch/pull/41574.patch
- https://github.com/elastic/elasticsearch/pull/41574.diff
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#41574>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABUXIWSKAJG44C2ASSVYADPSLYVDANCNFSM4HIVGAZQ>
.
|
nik9000
requested changes
Apr 30, 2019
| ++++ | ||
| <titleabbrev>Delete {dataframe-transforms}</titleabbrev> | ||
| <titleabbrev>Delete data frame transforms</titleabbrev> |
There was a problem hiding this comment.
I think you can revert this line now that you have subs=attributes.
| ++++ | ||
| <titleabbrev>Get {dataframe-transform} statistics</titleabbrev> | ||
| <titleabbrev>Get data frame transform statistics</titleabbrev> |
There was a problem hiding this comment.
Same for all of the others actually.
…ration" This reverts commit 98f1302.
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
akhil10x5
pushed a commit
to akhil10x5/elasticsearch
that referenced
this pull request
May 2, 2019
…igration (elastic#41574) * [DOCS] Replace attributes in titleabbrevs for Asciidoctor migration * [DOCS] Add [subs="attributes"] so attributes render in Asciidoctor * Revert "[DOCS] Replace attributes in titleabbrevs for Asciidoctor migration" This reverts commit 98f1302. * [DOCS] Fix merge conflict
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…igration (elastic#41574) * [DOCS] Replace attributes in titleabbrevs for Asciidoctor migration * [DOCS] Add [subs="attributes"] so attributes render in Asciidoctor * Revert "[DOCS] Replace attributes in titleabbrevs for Asciidoctor migration" This reverts commit 98f1302. * [DOCS] Fix merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Asciidoctor does not expand attributes included in
<titleabbrev>tags. This Adds the[subs="attributes"]to<titleabbrev>tags containing attributes in preparation for the Asciidoctor migrationRelates to /elastic/docs#827 and #41128.