Bump the minimum Java version to Java 11 #40754

jasontedor · 2019-04-02T21:48:28Z

With the 8.0.0 release of Elasticsearch we will bump the minimum required Java to Java 11. This commit puts this into effect on the master branch.

elasticmachine · 2019-04-02T21:48:30Z

Pinging @elastic/es-core-infra

jasontedor · 2019-04-02T22:10:20Z

@jkakavas FYI this means that we will need a java11fips JVM in CI to continue supporting FIPS.

jasontedor · 2019-04-03T02:27:19Z

@danielmitterdorfer This will disrupt performance benchmarks, how do you want to proceed?

jpountz

What I understand looks good, but please wait for @rjernst's review before pushing as I'm not very familiar with the build.

It looks like we could do minor simplifications in BuildPlugin.groovy and PrecommitTasks.groovy, which check for project.runtimeJavaVersion >= JavaVersion.VERSION_1_9, which would always be true now, and project.compilerJavaVersion < JavaVersion.VERSION_1_10 which would always evaluate to false?

jpountz · 2019-04-03T07:23:05Z

docs/reference/migration/migrate_8_0/packaging.asciidoc

+//tag::notable-breaking-changes[]
+==== Java 11 is required
+
+Java 11 is now required to run Elasticsearch and any of its command line tools.


do we need to say "11 or greater" to clarify that more recent versions are fine?

jpountz · 2019-04-03T07:40:10Z

server/build.gradle

@@ -34,39 +34,39 @@ publishing {

 archivesBaseName = 'elasticsearch'

-// we want to keep the JDKs in our IDEs set to JDK 8 until minimum JDK is bumped to 9 so we do not include this source set in our IDEs
+// we want to keep the JDKs in our IDEs set to JDK 11 until minimum JDK is bumped to 17 so we do not include this source set in our IDEs


I think it should be 18? The next LTS release?

Yeah, I was going for the next LTS release which I had in my head was 17. I think that's right though? JDK LTS releases every three years, 11 was in September 2018 so the next one would be September 2021 which would be:

13 September 2019

14 March 2020

15 September 2020

16 March 2021

17 September 2021

jpountz · 2019-04-03T07:42:23Z

server/src/main/java/org/elasticsearch/monitor/jvm/JvmInfo.java

-                configuredMaxHeapSize, mem, inputArguments, bootClassPath, classPath, systemProperties, gcCollectors, memoryPools, onError,
-                onOutOfMemoryError, useCompressedOops, useG1GC, useSerialGC);
+        INSTANCE = new JvmInfo(
+                ProcessHandle.current().pid(),


note to other reviewers: this line is the thing that changed

Elasticsearch master bumps the minimum Java version to Java 11. With this commit we follow suit. Relates elastic/elasticsearch#40754

Elasticsearch master bumps the minimum Java version to Java 11. With this commit we follow suit. Relates elastic/elasticsearch#40754 Relates #25

danielmitterdorfer · 2019-04-03T11:29:07Z

@danielmitterdorfer This will disrupt performance benchmarks, how do you want to proceed?

Thanks for the ping; highly appreciated. We're all set from a benchmarking perspective and the cutover benchmarking run has just been triggered. From now on all our nightly benchmarks will run with OpenJDK 11.0.2.

alpar-t

Thanks! I left some comments and questions.
Note to self, there's some cleanup in buildSrc/build.gradle that is made possible by this PR.

alpar-t · 2019-04-03T11:27:27Z

.ci/matrix-runtime-javas.yml

@@ -6,11 +6,8 @@
 # or 'openjdk' followed by the major release number.

 ES_RUNTIME_JAVA:
-  - java8
-  - java8fips


Shouldn't we have an alternative before removing this?
There's #37250 so this will not fall trough the cracks, but in the interim we will have no fips testing,
and fips might have to play catch-up once we get the tests back.
I think that's something we should generally try to avoid in CI.

I discussed this with @jkakavas and he will be working on getting a FIPS-compliant JDK 11 ready, but agreed that can happen independently. He will focus on that in the upcoming week.

alpar-t · 2019-04-03T11:33:41Z

Vagrantfile

@@ -246,6 +246,10 @@ def linux_common(config,
    touch /is_vagrant_vm # for consistency between linux and windows
  SHELL

+  config.vm.provision 'jdk-11', type: 'shell', inline: <<-SHELL
+    curl -sSL https://download.java.net/java/GA/jdk11/9/GPL/openjdk-11.0.2_linux-x64_bin.tar.gz | tar xz -C /opt/


This can potentially lead to more CI failures due to network issues.
On the other hand I'm not sure we need to pull in any JDK for the packaging tests,
AFAIK we test with the java version from the platform under test, if this is to old we should just stick to the bundled one or have the set set JAVA_HOME to that location of that's what we want to test.

We need a non-bundled JDK in the image that can run Elasticsearch to test that a non-bundled JDK works. The installed JDK 8s would be too old, so we need JDK 11.

alpar-t · 2019-04-03T11:37:39Z

server/build.gradle

@@ -34,39 +34,39 @@ publishing {

 archivesBaseName = 'elasticsearch'

-// we want to keep the JDKs in our IDEs set to JDK 8 until minimum JDK is bumped to 9 so we do not include this source set in our IDEs
+// we want to keep the JDKs in our IDEs set to JDK 11 until minimum JDK is bumped to 17 so we do not include this source set in our IDEs


Why aren't we removing the additional source set just like we did for libs ?
Are we anticipating a need to to MR jars for java 12 ?

Yeah, I'm anticipating that indeed.

rjernst

LGTM

rjernst · 2019-04-04T06:12:09Z

Vagrantfile

 fi
 export SYSTEM_JAVA_HOME=\\\$JAVA_HOME
 unset JAVA_HOME
+export PATH=/opt/jdk-11.0.2/bin:\\\$PATH


Why is this added to path? The packaging tests don't use java on path anymore.

We do use Java on the path. We have lines like:

local java=$(which java)

I'll rework these tests so that they aren't using Java from the path.

Here is one example:

elasticsearch/qa/vagrant/src/test/resources/packaging/tests/module_and_plugin_test_cases.bash

Line 433 in fef2153

local java=$(which java)

rjernst · 2019-04-04T06:13:46Z

server/build.gradle

@@ -34,39 +34,39 @@ publishing {

 archivesBaseName = 'elasticsearch'

-// we want to keep the JDKs in our IDEs set to JDK 8 until minimum JDK is bumped to 9 so we do not include this source set in our IDEs
+// we want to keep the JDKs in our IDEs set to JDK 11 until minimum JDK is bumped to 17 so we do not include this source set in our IDEs


I think it should be 18? The next LTS release?

* master: (77 commits) Suppress lease background sync failures if stopping (elastic#40902) [DOCS] Added settings page for ILM. (elastic#40880) [Docs] Remove extraneous text (elastic#40914) Move test classes to test root in Painless (elastic#40873) Fix date index name processor default date_formats (elastic#40915) Source additional files correctly in elasticsearch-cli (elastic#40890) Allow AVX-512 on JDK 11+ (elastic#40828) [Docs] Change example to show col headers (elastic#40822) Update apache httpclient to version 4.5.8 (elastic#40875) Update monitoring-kibana.json (elastic#40899) Introduce Delegating ActionListener Wrappers (elastic#40129) Deprecate old transport settings (elastic#40821) Add Kibana application privileges for monitoring and ml reserved roles (elastic#40651) Use Writeable for TransportReplAction derivatives (elastic#40894) Add test for HTTP and Transport TLS on basic license (elastic#40714) Remove unneded cluster config from test (elastic#40856) Make Fuzziness reject illegal values earlier (elastic#33511) Remove test-only customisation from TransReplAct (elastic#40863) Fix dense/sparse vector limit documentation (elastic#40852) Make -try xlint warning disabled by default. (elastic#40833) ...

jasontedor · 2019-04-06T15:36:07Z

@elasticmachine run elasticsearch-ci/2

* elastic/master: Fix Failing to Handle Ex. in TransportShardBulkAction (elastic#40923) Be lenient when parsing build flavor and type on the wire (elastic#40734) Make Transport Shard Bulk Action Async (elastic#39793)

* elastic/master: Mute failing IndexShard local history test

With the 8.0.0 release of Elasticsearch we will bump the minimum required Java to Java 11. This commit puts this into effect on the master branch.

The logger usage check uses its own version of ASM to inspect class files for logging usages. Master was updated to support java 11 compilation in #40754. However, 7.x still used ASM 5, which could not read newer java bytecode versions. This commit bumps ASM in 7.x used in the logger usage check. closes #52408

jasontedor added 2 commits April 2, 2019 17:44

Bump the minimum Java version to Java 11

b012e02

With the 8.0.0 release of Elasticsearch we will bump the minimum required Java to Java 11. This commit puts this into effect on the master branch.

Add breaking change

64a31b1

jasontedor added >enhancement >breaking :Delivery/Build Build or test infrastructure v8.0.0 labels Apr 2, 2019

jasontedor requested review from rjernst and jpountz April 2, 2019 21:48

jasontedor mentioned this pull request Apr 2, 2019

Deprecate versions of Java prior to Java 11 #40756

Merged

CI versions

4679b61

spalger pushed a commit to spalger/kibana that referenced this pull request Apr 2, 2019

test against elastic/elasticsearch#40754

b10118b

jasontedor added 2 commits April 2, 2019 19:22

Update shadow for new JDK

f4a7816

Temporaily provision JDK 11 in packaging tests

b37935e

jpountz approved these changes Apr 3, 2019

View reviewed changes

danielmitterdorfer added a commit to danielmitterdorfer/rally-teams that referenced this pull request Apr 3, 2019

Bump minimum Java version to Java 11

543da6e

Elasticsearch master bumps the minimum Java version to Java 11. With this commit we follow suit. Relates elastic/elasticsearch#40754

danielmitterdorfer mentioned this pull request Apr 3, 2019

Bump minimum Java version to Java 11 elastic/rally-teams#25

Merged

danielmitterdorfer added a commit to elastic/rally-teams that referenced this pull request Apr 3, 2019

Bump minimum Java version to Java 11

6ab656e

Elasticsearch master bumps the minimum Java version to Java 11. With this commit we follow suit. Relates elastic/elasticsearch#40754 Relates #25

alpar-t reviewed Apr 3, 2019

View reviewed changes

rjernst approved these changes Apr 4, 2019

View reviewed changes

jasontedor added 3 commits April 6, 2019 10:21

Fix docs to say 11 or higher

2842b9b

Remove unnecessary setting of the path

795cbc6

jasontedor added 3 commits April 6, 2019 13:49

Remove use of Java on path in packaging tests

845d9ab

Bump docs version

ecfcf7a

Simplifications

c932ca7

jasontedor added 6 commits April 7, 2019 09:30

Fix test

e3953c2

Merge remote-tracking branch 'elastic/master' into minimum-java-11

50dba05

* elastic/master: Fix Failing to Handle Ex. in TransportShardBulkAction (elastic#40923) Be lenient when parsing build flavor and type on the wire (elastic#40734) Make Transport Shard Bulk Action Async (elastic#39793)

Fix java packaging tests execution

9c2bfbb

Merge remote-tracking branch 'elastic/master' into minimum-java-11

e9317be

* elastic/master: Mute failing IndexShard local history test

Fix packaging tests

e90b710

Remove dead local

1c7e299

jasontedor merged commit 8deadfb into elastic:master Apr 7, 2019

jasontedor deleted the minimum-java-11 branch April 7, 2019 20:16

This was referenced Apr 8, 2019

Update contributing docs to reflect JDK 11 #40955

Merged

Cleanup JVM options after JDK 11 bump #40961

Merged

jkakavas mentioned this pull request Apr 16, 2019

Add a FIPS 140-2 enabled JDK 11 JVM in CI #37250

Closed

This was referenced May 22, 2019

Add deprecation check for Java version #41092

Closed

Update Deprecation Info API checks for 8.0 #42404

Closed

rjernst mentioned this pull request Feb 25, 2020

Update to ASM 7.1 in logger usage check #52742

Merged

mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020

pugnascotia mentioned this pull request Nov 12, 2020

Add deprecation check for Java version #64996

Merged

jakelandis mentioned this pull request Feb 22, 2021

DRAFT [META] REST Compatible API V7 completeness #68905

Closed

jakelandis added v8.0.0-alpha1 and removed v8.0.0 labels Jul 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump the minimum Java version to Java 11 #40754

Bump the minimum Java version to Java 11 #40754

jasontedor commented Apr 2, 2019

elasticmachine commented Apr 2, 2019

jasontedor commented Apr 2, 2019

jasontedor commented Apr 3, 2019

jpountz left a comment

jpountz Apr 3, 2019

jpountz Apr 3, 2019

rjernst Apr 4, 2019

jasontedor Apr 6, 2019

jpountz Apr 3, 2019

danielmitterdorfer commented Apr 3, 2019

alpar-t left a comment

alpar-t Apr 3, 2019

jasontedor Apr 6, 2019

alpar-t Apr 3, 2019

jasontedor Apr 6, 2019

alpar-t Apr 3, 2019

jasontedor Apr 6, 2019

rjernst left a comment

rjernst Apr 4, 2019

jasontedor Apr 6, 2019

jasontedor Apr 6, 2019

rjernst Apr 4, 2019

jasontedor commented Apr 6, 2019

Bump the minimum Java version to Java 11 #40754

Bump the minimum Java version to Java 11 #40754

Conversation

jasontedor commented Apr 2, 2019

elasticmachine commented Apr 2, 2019

jasontedor commented Apr 2, 2019

jasontedor commented Apr 3, 2019

jpountz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danielmitterdorfer commented Apr 3, 2019

alpar-t left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rjernst left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasontedor commented Apr 6, 2019