Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust log and unmute testFailOverOnFollower #38762

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 12, 2019

There were two documents (seq=2 and seq=103) missing on the follower in one of the failures of testFailOverOnFollower. I spent several hours on that failure but could not figure out the reason. I adjust log and unmute this test so we can collect more information.

Relates #38633

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features v8.0.0 v7.2.0 labels Feb 12, 2019
@dnhatn dnhatn requested a review from martijnvg February 12, 2019 03:59
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Feb 12, 2019

Thanks @martijnvg

@dnhatn dnhatn merged commit d003530 into elastic:master Feb 12, 2019
@dnhatn dnhatn deleted the test/log-failover branch February 12, 2019 16:41
dnhatn added a commit that referenced this pull request Feb 12, 2019
There were two documents (seq=2 and seq=103) missing on the follower in
one of the failures of `testFailOverOnFollower`. I spent several hours
on that failure but could not figure out the reason. I adjust log and
unmute this test so we can collect more information.

Relates #38633
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 13, 2019
* master:
  Remove _type term filters from cluster alert watches (elastic#38819)
  Adjust log and unmute testFailOverOnFollower (elastic#38762)
  Fix line separators in JSON logging tests (elastic#38771)
  Fix synchronization in LocalCheckpointTracker#contains (elastic#38755)
  muted test
  Remove TLSv1.2 pinning in ssl reload tests (elastic#38651)
  Don't fail init script if `/proc/.../max_map_count` absent (elastic#35933)
  Format Watcher.status.lastChecked and lastMetCondition (elastic#38626)
  SQL: Implement `::` cast operator (elastic#38774)
  Ignore failing test
@dnhatn dnhatn added the v7.0.0 label Feb 23, 2019
dnhatn added a commit that referenced this pull request Feb 23, 2019
There were two documents (seq=2 and seq=103) missing on the follower in
one of the failures of `testFailOverOnFollower`. I spent several hours
on that failure but could not figure out the reason. I adjust log and
unmute this test so we can collect more information.

Relates #38633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CCR Issues around the Cross Cluster State Replication features >test Issues or PRs that are addressing/adding tests v7.0.0-rc1 v7.2.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants