Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document scroll param on reindex.json #38615

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Feb 8, 2019

The Reindex API also exposes scroll as a querystring parameter.

cc @elastic/es-clients

The Reindex API also exposes `scroll` as a querystring parameter.
@matriv matriv added >docs General docs changes :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. labels Feb 11, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"scroll": {
"type" : "time",
"description" : "Control how long to keep the search context alive",
"default" : "5m"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did you find the 5m default again?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both work exactly how they work in the Bulk API. As _reindex uses scroll search, you can also specify the scroll parameter to control how long it keeps the "search context" alive, (e.g. ?scroll=10m). The default value is 5 minutes.

https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-reindex.html

@javanna
Copy link
Member

javanna commented Feb 25, 2019

this seems to be a duplicate of #31316, but the content is slightly different as this one contains the default. @Mpdreamz can you clarify that so we decide which one of the two PRs we should get in? :)

@Mpdreamz
Copy link
Member Author

Mpdreamz commented Mar 4, 2019

run elasticsearch-ci/bwc

@Mpdreamz Mpdreamz added the :Core/Infra/REST API REST infrastructure and utilities label Mar 4, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@javanna javanna merged commit 1c42178 into master Mar 7, 2019
javanna pushed a commit that referenced this pull request Mar 7, 2019
The Reindex API also exposes `scroll` as a querystring parameter.
javanna pushed a commit that referenced this pull request Mar 7, 2019
The Reindex API also exposes `scroll` as a querystring parameter.
@jpountz
Copy link
Contributor

jpountz commented Jul 5, 2019

@Mpdreamz I'm assuming there is nothing left to backport and removed the backport pending label.

@Mpdreamz Mpdreamz deleted the rest-spec-reindex-scroll branch July 5, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/REST API REST infrastructure and utilities :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >docs General docs changes v7.3.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants