Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLRC - Implement Get API keys API #38083

Merged
merged 14 commits into from
Feb 2, 2019

Conversation

bizybot
Copy link
Contributor

@bizybot bizybot commented Jan 31, 2019

This commit adds support for Get API keys API
to the high-level rest client.
The API allows users to retrieve API key information
by finding API keys for the given:

  • API key id
  • API key name
  • username and/or realm name

This commit adds support for Get API keys
to high level rest client.
@bizybot bizybot added >non-issue :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) labels Jan 31, 2019
@bizybot bizybot requested review from jaymode and jkakavas January 31, 2019 11:06
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Yogesh, left some minor suggestions

jkakavas and others added 4 commits February 2, 2019 01:31
Co-Authored-By: bizybot <902768+bizybot@users.noreply.github.com>
Co-Authored-By: bizybot <902768+bizybot@users.noreply.github.com>
Co-Authored-By: bizybot <902768+bizybot@users.noreply.github.com>
Co-Authored-By: bizybot <902768+bizybot@users.noreply.github.com>
Copy link
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jkakavas and others added 8 commits February 2, 2019 12:44
Co-Authored-By: bizybot <902768+bizybot@users.noreply.github.com>
Co-Authored-By: bizybot <902768+bizybot@users.noreply.github.com>
Co-Authored-By: bizybot <902768+bizybot@users.noreply.github.com>
- correct documentation
- use List instead of arrays
Co-Authored-By: bizybot <902768+bizybot@users.noreply.github.com>
@bizybot bizybot merged commit 376c625 into elastic:security_api_keys Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants