Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct deprec log in RestGetFieldMappingAction #37843

Conversation

mayya-sharipova
Copy link
Contributor

@mayya-sharipova mayya-sharipova commented Jan 25, 2019

Correct a class used for deprecation logging in
RestGetFieldMappingAction

Relates to #37667

Correct a class used for deprecation logging in
RestGetFieldMappingAction
@mayya-sharipova mayya-sharipova added >bug :Search Foundations/Mapping Index mappings, including merging and defining field types labels Jan 25, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mayya-sharipova! I just realized I made the same mistake in RestCreateIndexAction -- maybe it would be possible to correct that class as well?

@mayya-sharipova
Copy link
Contributor Author

@elasticmachine run elaticsearch-ci-1

@mayya-sharipova
Copy link
Contributor Author

@elasticmachine run elaticsearch-ci/1

@mayya-sharipova
Copy link
Contributor Author

@jtibshirani Sure, Julie, I will add a commit to this PR to correct RestCreateIndexAction as well

Correct a class used for deprecation logging in
RestCreateIndexAction
@mayya-sharipova mayya-sharipova merged commit 70af3c7 into elastic:master Jan 25, 2019
@mayya-sharipova mayya-sharipova deleted the correct_log_class_restgetfieldmappingaction branch January 25, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search Foundations/Mapping Index mappings, including merging and defining field types v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants