Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Rolling upgrade with old internal indices #37184

Conversation

albertzaharovits
Copy link
Contributor

@albertzaharovits albertzaharovits commented Jan 7, 2019

Upgrading the Elastic Stack perfectly documents the process to upgrade ES from 5 to 6 when internal indices are present. However, the rolling upgrade docs do not mention anything about internal indices.

This adds a warning in the rolling upgrade procedure, highlighting that internal indices should be upgraded before the rolling upgrade procedure can be started.

Closes #36984

@albertzaharovits albertzaharovits self-assigned this Jan 7, 2019
@albertzaharovits albertzaharovits requested a review from lcawl January 7, 2019 11:39
@albertzaharovits albertzaharovits changed the base branch from master to 6.x January 7, 2019 11:41
@albertzaharovits albertzaharovits changed the base branch from 6.x to master January 7, 2019 11:41
@colings86 colings86 added the :Docs label Jan 7, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@@ -18,6 +18,12 @@ you can do a rolling upgrade you must encrypt the internode-communication with
SSL/TLS, which requires a full cluster restart. For more information about this
requirement and the associated bootstrap check, see <<bootstrap-checks-tls>>.

WARNING: The format used for the internal indices used by Kibana and {xpack}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we're trying to get away from using "X-Pack" terminology. It hasn't been cleaned up everywhere yet, but if we can use something else here, that would be great. Would it be correct to say something like "the Elastic Stack commercial features" instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am aware that the lingo had changed, but this is a warning message for users of 5.6 when X-Pack is still referred. Moreover, the proper stack upgrade docs in https://www.elastic.co/guide/en/elastic-stack/current/upgrading-elastic-stack.html, where the internal index upgrade step is described, still mention "X-Pack". I think using a different terminology would be confusing in this circumstance.

The decision is yours though, "The format used for the internal indices used by commercial features has changed in 6.x .", sounds equally fine to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I cleaned up some occurrences of X-Pack in that book yesterday, but there are still lots that seem relevant. This seems like one of those cases.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertzaharovits albertzaharovits merged commit 4efbda1 into elastic:master Jan 9, 2019
@albertzaharovits albertzaharovits deleted the rolling_upgrade_with_internal_indices branch January 9, 2019 16:14
albertzaharovits added a commit that referenced this pull request Jan 9, 2019
Upgrading the Elastic Stack perfectly documents the process to
upgrade ES from 5 to 6 when internal indices are present. However,
the rolling upgrade docs do not mention anything about internal indices.

This adds a warning in the rolling upgrade procedure, highlighting that
internal indices should be upgraded before the rolling upgrade procedure
can be started.
albertzaharovits added a commit that referenced this pull request Jan 9, 2019
Upgrading the Elastic Stack perfectly documents the process to
upgrade ES from 5 to 6 when internal indices are present. However,
the rolling upgrade docs do not mention anything about internal indices.

This adds a warning in the rolling upgrade procedure, highlighting that
internal indices should be upgraded before the rolling upgrade procedure
can be started.
albertzaharovits added a commit that referenced this pull request Jan 9, 2019
Upgrading the Elastic Stack perfectly documents the process to
upgrade ES from 5 to 6 when internal indices are present. However,
the rolling upgrade docs do not mention anything about internal indices.

This adds a warning in the rolling upgrade procedure, highlighting that
internal indices should be upgraded before the rolling upgrade procedure
can be started.
albertzaharovits added a commit that referenced this pull request Jan 9, 2019
Upgrading the Elastic Stack perfectly documents the process to
upgrade ES from 5 to 6 when internal indices are present. However,
the rolling upgrade docs do not mention anything about internal indices.

This adds a warning in the rolling upgrade procedure, highlighting that
internal indices should be upgraded before the rolling upgrade procedure
can be started.
albertzaharovits added a commit that referenced this pull request Jan 9, 2019
Upgrading the Elastic Stack perfectly documents the process to
upgrade ES from 5 to 6 when internal indices are present. However,
the rolling upgrade docs do not mention anything about internal indices.

This adds a warning in the rolling upgrade procedure, highlighting that
internal indices should be upgraded before the rolling upgrade procedure
can be started.
albertzaharovits added a commit that referenced this pull request Jan 9, 2019
Upgrading the Elastic Stack perfectly documents the process to
upgrade ES from 5 to 6 when internal indices are present. However,
the rolling upgrade docs do not mention anything about internal indices.

This adds a warning in the rolling upgrade procedure, highlighting that
internal indices should be upgraded before the rolling upgrade procedure
can be started.
albertzaharovits added a commit that referenced this pull request Jan 9, 2019
Upgrading the Elastic Stack perfectly documents the process to
upgrade ES from 5 to 6 when internal indices are present. However,
the rolling upgrade docs do not mention anything about internal indices.

This adds a warning in the rolling upgrade procedure, highlighting that
internal indices should be upgraded before the rolling upgrade procedure
can be started.
albertzaharovits added a commit that referenced this pull request Jan 9, 2019
Upgrading the Elastic Stack perfectly documents the process to
upgrade ES from 5 to 6 when internal indices are present. However,
the rolling upgrade docs do not mention anything about internal indices.

This adds a warning in the rolling upgrade procedure, highlighting that
internal indices should be upgraded before the rolling upgrade procedure
can be started.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants