[Backport] Add hybridfs store type #37067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we introduce a new store type `hybridfs` that is a hybrid between `mmapfs` and `niofs`. This store type chooses different strategies to read Lucene files based on the read access pattern (random or linear) in order to optimize performance. This store type has been available in earlier versions of Elasticsearch as `default_fs`. We have chosen a different name now in order to convey the intent of the store type instead of tying it to the fact whether it is the default choice. Relates elastic#36668
|
Pinging @elastic/es-distributed |
|
Note to reviewers: This is identical to #36668 except that |
jpountz
approved these changes
Jan 2, 2019
danielmitterdorfer
added a commit
that referenced
this pull request
Jan 4, 2019
With this commit we deprecate the setting `node.store.allow_mmapfs` and add a new setting `node.store.allow_mmap`. Previously this setting has controlled whether `mmapfs` could be used as a store type. With the introduction of `hybridfs` which also relies on memory-mapping the old setting name is no longer appropriate as it also applies to `hybridfs`and thus we rename it in order to convey that it is actually used to allow memory-mapping but not a specific store type. Relates #37067 Relates #37070 Relates #37095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we introduce a new store type
hybridfsthat is ahybrid between
mmapfsandniofs. This store type chooses differentstrategies to read Lucene files based on the read access pattern (random
or linear) in order to optimize performance.
This store type has been available in earlier versions of Elasticsearch
as
default_fs. We have chosen a different name now in order to conveythe intent of the store type instead of tying it to the fact whether it
is the default choice.
Relates #36668